public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* strange code in ra-build.c:handle_asm_insn
@ 2002-12-23 10:22 Joern Rennecke
  2002-12-24 12:30 ` Denis Chertykov
  0 siblings, 1 reply; 2+ messages in thread
From: Joern Rennecke @ 2002-12-23 10:22 UTC (permalink / raw)
  To: Michael Matz; +Cc: gcc

Why do you call REG_CLASS_FROM_LETTER when you encounter digits
between 5 and 9?

              case '=': case '+': case '*': case '%': case '?': case '!':
              case '0': case '1': case '2': case '3': case '4': case 'm':
              case '<': case '>': case 'V': case 'o': case '&': case 'E':
              case 'F': case 's': case 'i': case 'n': case 'X': case 'I':
              case 'J': case 'K': case 'L': case 'M': case 'N': case 'O':
              case 'P':
                break;
...
              default:
                cls =
                  (int) reg_class_subunion[cls][(int)
                                                REG_CLASS_FROM_LETTER (c)];

-- 
--------------------------
SuperH (UK) Ltd.
2410 Aztec West / Almondsbury / BRISTOL / BS32 4QX
T:+44 1454 465658

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: strange code in ra-build.c:handle_asm_insn
  2002-12-23 10:22 strange code in ra-build.c:handle_asm_insn Joern Rennecke
@ 2002-12-24 12:30 ` Denis Chertykov
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Chertykov @ 2002-12-24 12:30 UTC (permalink / raw)
  To: Joern Rennecke; +Cc: Michael Matz, gcc

Joern Rennecke <joern.rennecke@superh.com> writes:

> Why do you call REG_CLASS_FROM_LETTER when you encounter digits
> between 5 and 9?
> 
>               case '=': case '+': case '*': case '%': case '?': case '!':
>               case '0': case '1': case '2': case '3': case '4': case 'm':
>               case '<': case '>': case 'V': case 'o': case '&': case 'E':
>               case 'F': case 's': case 'i': case 'n': case 'X': case 'I':
>               case 'J': case 'K': case 'L': case 'M': case 'N': case 'O':
>               case 'P':
>                 break;
> ...
>               default:
>                 cls =
>                   (int) reg_class_subunion[cls][(int)
>                                                 REG_CLASS_FROM_LETTER (c)];

IMHO: The handle_asm_insn used only for debugging.
IMHO: Michael just copied and modified  reload1.c:maybe_fix_stack_asms.
maybe_fix_stack_asms still have equal part.
It's a bug.

Denis.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-12-24 17:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-23 10:22 strange code in ra-build.c:handle_asm_insn Joern Rennecke
2002-12-24 12:30 ` Denis Chertykov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).