mainline breakage (r148442)

mainline breakage (r148442)

[Oliver Kellogg]

Anybody else seeing this?

/usr/src/packages/BUILD/build-gcc-orig/./prev-gcc/xgcc
-B/usr/src/packages/BUILD/build-gcc-orig/./prev-gcc/
-B/opt/gnat/fsf/i686-pc-linux-gnu/bin/
-B/opt/gnat/fsf/i686-pc-linux-gnu/bin/
-B/opt/gnat/fsf/i686-pc-linux-gnu/lib/
-isystem /opt/gnat/fsf/i686-pc-linux-gnu/include
-isystem /opt/gnat/fsf/i686-pc-linux-gnu/sys-include    -c  -g
-fomit-frame-pointer -DIN_GCC   -W -Wall -Wwrite-strings
-Wstrict-prototypes -Wmissing-prototypes -Wcast-qual
-Wold-style-definition -Wc++-compat -Wmissing-format-attribute -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror
-fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../SOURCES/gcc/gcc
-I../../../SOURCES/gcc/gcc/. -I../../../SOURCES/gcc/gcc/../include
-I../../../SOURCES/gcc/gcc/../libcpp/include
-I../../../SOURCES/gcc/gcc/../libdecnumber
-I../../../SOURCES/gcc/gcc/../libdecnumber/bid
-I../libdecnumber    ../../../SOURCES/gcc/gcc/tree-eh.c -o tree-eh.o
cc1: warnings being treated as errors
../../../SOURCES/gcc/gcc/tree-eh.c: In function
‘lower_try_finally_switch’:
../../../SOURCES/gcc/gcc/tree-eh.c:1350:5: error: ‘tf_loc’ may be used
uninitialized in this function
make[3]: *** [tree-eh.o] Error 1
make[3]: Leaving directory `/usr/src/packages/BUILD/build-gcc-orig/gcc'
make[2]: *** [all-stage2-gcc] Error 2
make[2]: Leaving directory `/usr/src/packages/BUILD/build-gcc-orig'
make[1]: *** [stage2-bubble] Error 2

Re: mainline breakage (r148442)

[Aldy Hernandez]

oliver.kellogg@t-online.de (Oliver Kellogg) writes:

> Anybody else seeing this?
>
> ‘lower_try_finally_switch’:
> ../../../SOURCES/gcc/gcc/tree-eh.c:1350:5: error: ‘tf_loc’ may be used
> uninitialized in this function

Funny, this was never picked up in any of my bootstraps, but it is
indeed a bug.

This is an obvious fix I will be committing as soon as tests are done.

	* tree-eh.c (lower_try_finally_switch): Initialize tf_loc.

Index: tree-eh.c
===================================================================
--- tree-eh.c	(revision 148490)
+++ tree-eh.c	(working copy)
@@ -1333,7 +1333,7 @@ lower_try_finally_switch (struct leh_sta
   gimple_seq finally;
   struct pointer_map_t *cont_map = NULL;
   /* The location of the TRY_FINALLY stmt.  */
-  location_t tf_loc;
+  location_t tf_loc = gimple_location (tf->try_finally_expr);
   /* The location of the finally block.  */
   location_t finally_loc;