public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove NO_DATA_STRING
@ 2019-08-30 19:07 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2019-08-30 19:07 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1f6d2f100ae6de462f1e81b5de17de059f6b17ef

commit 1f6d2f100ae6de462f1e81b5de17de059f6b17ef
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jul 14 08:21:16 2019 -0600

    Remove NO_DATA_STRING
    
    NO_DATA_STRING shouldn't be used.  It's referenced in a single spot,
    in tui_data_window::display_all_data.  This patch removes the use and
    replaces it with the more correct text.  A later patch (though not in
    this series) will remove this call entirely, when it's more obviously
    correct to do so.
    
    gdb/ChangeLog
    2019-08-30  Tom Tromey  <tom@tromey.com>
    
    	* tui/tui-regs.c (tui_data_window::display_all_data): Change
    	text.
    	* tui/tui-data.h (NO_DATA_STRING): Remove define.

Diff:
---
 gdb/ChangeLog      | 6 ++++++
 gdb/tui/tui-data.h | 1 -
 gdb/tui/tui-regs.c | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fba2f4a..0cb864f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-08-30  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-regs.c (tui_data_window::display_all_data): Change
+	text.
+	* tui/tui-data.h (NO_DATA_STRING): Remove define.
+
 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 	    Sergio Durigan Junior  <sergiodj@redhat.com>
 
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index f430356..1810fa3 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -98,7 +98,6 @@ public:
 
 /* Constant definitions.  */
 #define DEFAULT_TAB_LEN         8
-#define NO_DATA_STRING          "[ No Data Values Displayed ]"
 #define SRC_NAME                "src"
 #define CMD_NAME                "cmd"
 #define DATA_NAME               "regs"
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 71037d4..24b182f 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -437,7 +437,7 @@ void
 tui_data_window::display_all_data ()
 {
   if (regs_content.empty ())
-    erase_data_content (NO_DATA_STRING);
+    erase_data_content (_("[ Register Values Unavailable ]"));
   else
     {
       erase_data_content (NULL);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-08-30 19:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 19:07 [binutils-gdb] Remove NO_DATA_STRING Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).