[binutils-gdb] Remove some calls in tui_data_window

[binutils-gdb] Remove some calls in tui_data_window

[Tom Tromey]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1bf2866a59530d9e8384807bc44b833e8647d329

commit 1bf2866a59530d9e8384807bc44b833e8647d329
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jul 14 09:11:46 2019 -0600

    Remove some calls in tui_data_window
    
    This patch removes a call to erase_data_content in refresh_all and
    then removes some other calls that are more clearly unnecessary once
    one follows calls from that point.
    
    gdb/ChangeLog
    2019-08-30  Tom Tromey  <tom@tromey.com>
    
    	* tui/tui-regs.c (tui_data_window::display_registers_from_line)
    	(tui_data_window::rerender): Don't call
    	check_and_display_highlight_if_needed.
    	(tui_data_window::refresh_all): Remove call to
    	erase_data_content.

Diff:
---
 gdb/ChangeLog      | 8 ++++++++
 gdb/tui/tui-regs.c | 8 +-------
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c8b69f4..b95be65 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
 2019-08-30  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-regs.c (tui_data_window::display_registers_from_line)
+	(tui_data_window::rerender): Don't call
+	check_and_display_highlight_if_needed.
+	(tui_data_window::refresh_all): Remove call to
+	erase_data_content.
+
+2019-08-30  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-regs.c (tui_data_window::last_regs_line_no)
 	(tui_data_window::display_registers_from)
 	(tui_data_window::display_reg_element_at_line)
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 636ae10..4a09a59 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -339,8 +339,6 @@ tui_data_window::display_reg_element_at_line (int start_element_no,
 int
 tui_data_window::display_registers_from_line (int line_no)
 {
-  check_and_display_highlight_if_needed ();
-
   int element_no;
 
   if (line_no < 0)
@@ -427,7 +425,6 @@ tui_data_window::rerender ()
     {
       erase_data_content (NULL);
       delete_data_content_windows ();
-      check_and_display_highlight_if_needed ();
       display_registers_from (0);
     }
 }
@@ -450,10 +447,7 @@ tui_data_window::refresh_all ()
 	    first_line = line_from_reg_element_no (first_element);
 
 	  if (first_line >= 0)
-	    {
-	      erase_data_content (NULL);
-	      display_registers_from_line (first_line);
-	    }
+	    display_registers_from_line (first_line);
 	}
     }
 }