public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] (Ada) do not print Ada task names in quotes in "info tasks" output
@ 2019-09-17 18:28 Joel Brobecker
  0 siblings, 0 replies; only message in thread
From: Joel Brobecker @ 2019-09-17 18:28 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=743321899674e03cf572fcfeb6c7705aded7c9a5

commit 743321899674e03cf572fcfeb6c7705aded7c9a5
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Tue Sep 17 13:27:55 2019 -0500

    (Ada) do not print Ada task names in quotes in "info tasks" output
    
    A recent change enhanced a couple of notifications about Ada tasks to
    include the task's name in addition to the task's number. That change
    also modified the output of the "info tasks" when printing the detailed
    information of one given task. I believe this change was unintentionally
    left over from the initial version after it was decided that quoting
    the task's name should not be done. This patch therefore undoes this
    part of the patch.
    
    gdb/ChangeLog:
    
            * ada-tasks.c (info_task): Remove quoting of the task's name.
    
    Tested on x86_64-linux, with both the official testsuite as well as
    AdaCore's testsuite.

Diff:
---
 gdb/ChangeLog   | 4 ++++
 gdb/ada-tasks.c | 6 +++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 59c6f75..c564fce 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-09-17  Joel Brobecker  <brobecker@adacore.com>
+
+	* ada-tasks.c (info_task): Remove quoting of the task's name.
+
 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 
 	* symfile.c (auto_solib_add): Replace comment with a reference
diff --git a/gdb/ada-tasks.c b/gdb/ada-tasks.c
index 34da786..24ceab1 100644
--- a/gdb/ada-tasks.c
+++ b/gdb/ada-tasks.c
@@ -1199,7 +1199,7 @@ info_task (struct ui_out *uiout, const char *taskno_str, struct inferior *inf)
 
   /* Print the name of the task.  */
   if (task_info->name[0] != '\0')
-    printf_filtered (_("Name: \"%s\"\n"), task_info->name);
+    printf_filtered (_("Name: %s\n"), task_info->name);
   else
     printf_filtered (_("<no name>\n"));
 
@@ -1220,7 +1220,7 @@ info_task (struct ui_out *uiout, const char *taskno_str, struct inferior *inf)
 
       printf_filtered (_("Parent: %d"), parent_taskno);
       if (parent->name[0] != '\0')
-        printf_filtered (" (\"%s\")", parent->name);
+        printf_filtered (" (%s)", parent->name);
       printf_filtered ("\n");
     }
   else
@@ -1253,7 +1253,7 @@ info_task (struct ui_out *uiout, const char *taskno_str, struct inferior *inf)
         ada_task_info *target_task_info = &data->task_list[target_taskno - 1];
 
         if (target_task_info->name[0] != '\0')
-          printf_filtered (" (\"%s\")", target_task_info->name);
+          printf_filtered (" (%s)", target_task_info->name);
       }
 
     printf_filtered ("\n");


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-17 18:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 18:28 [binutils-gdb] (Ada) do not print Ada task names in quotes in "info tasks" output Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).