public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Declare dwarf_always_disassemble in dwarf2read.h
@ 2019-09-20  0:14 Christian Biesinger
  0 siblings, 0 replies; only message in thread
From: Christian Biesinger @ 2019-09-20  0:14 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e86f08d28f469b9400e91bbaf1b0a5e7f697732a

commit e86f08d28f469b9400e91bbaf1b0a5e7f697732a
Author: Christian Biesinger <cbiesinger@google.com>
Date:   Thu Sep 19 13:26:55 2019 +0900

    Declare dwarf_always_disassemble in dwarf2read.h
    
    And remove the declaration from dwarf2loc.c, for better typesafety.
    
    gdb/ChangeLog:
    
    2019-09-19  Christian Biesinger  <cbiesinger@google.com>
    
    	* dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
    	* dwarf2read.h: Declare dwarf_always_disassemble.

Diff:
---
 gdb/ChangeLog    | 5 +++++
 gdb/dwarf2loc.c  | 2 --
 gdb/dwarf2read.h | 2 ++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 39f917b..45e6e79 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-09-19  Christian Biesinger  <cbiesinger@google.com>
+
+	* dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
+	* dwarf2read.h: Declare dwarf_always_disassemble.
+
 2019-09-19  Tom de Vries  <tdevries@suse.de>
 
 	PR gdb/25009
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 29fccae..c8ba029 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -46,8 +46,6 @@
 #include "gdbsupport/underlying.h"
 #include "gdbsupport/byte-vector.h"
 
-extern bool dwarf_always_disassemble;
-
 static struct value *dwarf2_evaluate_loc_desc_full (struct type *type,
 						    struct frame_info *frame,
 						    const gdb_byte *data,
diff --git a/gdb/dwarf2read.h b/gdb/dwarf2read.h
index 8939f97..e9b9462 100644
--- a/gdb/dwarf2read.h
+++ b/gdb/dwarf2read.h
@@ -33,6 +33,8 @@ extern struct cmd_list_element *show_dwarf_cmdlist;
 typedef struct dwarf2_per_cu_data *dwarf2_per_cu_ptr;
 DEF_VEC_P (dwarf2_per_cu_ptr);
 
+extern bool dwarf_always_disassemble;
+
 /* A descriptor for dwarf sections.
 
    S.ASECTION, SIZE are typically initialized when the objfile is first


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-20  0:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20  0:14 [binutils-gdb] Declare dwarf_always_disassemble in dwarf2read.h Christian Biesinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).