public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix incomplete regexps in step-precsave.exp
@ 2019-09-27 15:05 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-09-27 15:05 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=060b3ab4edadfc0d55e606598769c1e5315fd74c

commit 060b3ab4edadfc0d55e606598769c1e5315fd74c
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Sep 27 17:04:59 2019 +0200

    [gdb/testsuite] Fix incomplete regexps in step-precsave.exp
    
    The commit 68f7d34dd50 "[gdb/testsuite] Add KFAIL for missing support of
    reverse-debugging of vmovd" rewrites a gdb_test into a gdb_test_multiple but
    forgets to add the $gdb_prompt part in the regexp.
    
    Add the missing parts of the regexps.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2019-09-27  Tom de Vries  <tdevries@suse.de>
    
    	* gdb.reverse/step-precsave.exp: Add missing $gdb_prompt in regexps.

Diff:
---
 gdb/testsuite/ChangeLog                     | 4 ++++
 gdb/testsuite/gdb.reverse/step-precsave.exp | 6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 625a70c..87f34d6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
 2019-09-27  Tom de Vries  <tdevries@suse.de>
 
+	* gdb.reverse/step-precsave.exp: Add missing $gdb_prompt in regexps.
+
+2019-09-27  Tom de Vries  <tdevries@suse.de>
+
 	PR record/23188
 	* gdb.reverse/step-precsave.exp: Add kfail for PR record/23188.
 
diff --git a/gdb/testsuite/gdb.reverse/step-precsave.exp b/gdb/testsuite/gdb.reverse/step-precsave.exp
index f5e1551..2073b8a 100644
--- a/gdb/testsuite/gdb.reverse/step-precsave.exp
+++ b/gdb/testsuite/gdb.reverse/step-precsave.exp
@@ -47,11 +47,13 @@ gdb_test "break $end_of_main" \
 # This can take awhile.
 with_timeout_factor 20 {
     set test "run to end of main"
+    set pass_pattern "Breakpoint .* end of main .*"
+    set kfail_pattern "Process record does not support instruction 0xc5 at.*"
     gdb_test_multiple "continue" $test {
-	-re "Breakpoint .* end of main .*" {
+	-re "\[\r\n\]*(?:$pass_pattern)\[\r\n\]+$gdb_prompt $" {
 	    pass $test
 	}
-	-re "Process record does not support instruction 0xc5 at.*$gdb_prompt $" {
+	-re "\[\r\n\]*(?:$kfail_pattern)\[\r\n\]+$gdb_prompt $" {
 	    kfail "record/23188" $test
 	}
     }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-27 15:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 15:05 [binutils-gdb] [gdb/testsuite] Fix incomplete regexps in step-precsave.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).