public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix x86_64 mingw build
@ 2021-05-03 18:42 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2021-05-03 18:42 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8228833924fa3c92a436a5f938a94dae180773f9
commit 8228833924fa3c92a436a5f938a94dae180773f9
Author: Tom Tromey <tromey@adacore.com>
Date: Mon May 3 08:57:46 2021 -0600
Fix x86_64 mingw build
PR build/27807 points out that my recent changes to the Windows port
missed a spot in win32-i386-low.cc -- a call to
win32_Wow64GetThreadContext remained, causing link errors in
gdbserver. This happened because I tested an i686 build, but this
code is only used on an x86_64 build.
This patch fixes the bug. I am checking it in.
gdbserver/ChangeLog
2021-05-03 Tom Tromey <tromey@adacore.com>
PR build/27807:
* win32-i386-low.cc (i386_get_thread_context): Call
Wow64GetThreadContext, not win32_Wow64GetThreadContext.
Diff:
---
gdbserver/ChangeLog | 6 ++++++
gdbserver/win32-i386-low.cc | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 057ed158be9..8ff59d1f486 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,9 @@
+2021-05-03 Tom Tromey <tromey@adacore.com>
+
+ PR build/27807:
+ * win32-i386-low.cc (i386_get_thread_context): Call
+ Wow64GetThreadContext, not win32_Wow64GetThreadContext.
+
2021-04-30 Tom Tromey <tromey@adacore.com>
* win32-low.cc (do_initial_child_stuff): Update.
diff --git a/gdbserver/win32-i386-low.cc b/gdbserver/win32-i386-low.cc
index 5fc4be0d4c7..e2afd2a8c17 100644
--- a/gdbserver/win32-i386-low.cc
+++ b/gdbserver/win32-i386-low.cc
@@ -260,7 +260,7 @@ i386_get_thread_context (windows_thread_info *th)
BOOL ret;
#ifdef __x86_64__
if (wow64_process)
- ret = win32_Wow64GetThreadContext (th->h, &th->wow64_context);
+ ret = Wow64GetThreadContext (th->h, &th->wow64_context);
else
#endif
ret = GetThreadContext (th->h, &th->context);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-03 18:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 18:42 [binutils-gdb] Fix x86_64 mingw build Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).