public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove fall throughs in core_target::xfer_partial.
@ 2022-03-17 16:38 John Baldwin
0 siblings, 0 replies; only message in thread
From: John Baldwin @ 2022-03-17 16:38 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0e30a3b0f233f828cc3274c2131ed31db275629c
commit 0e30a3b0f233f828cc3274c2131ed31db275629c
Author: John Baldwin <jhb@FreeBSD.org>
Date: Thu Mar 17 09:37:24 2022 -0700
Remove fall throughs in core_target::xfer_partial.
The cases for TARGET_OBJECT_LIBRARIES and TARGET_OBJECT_LIBRARIES_AIX
can try to fetch different data objects (such as
TARGET_OBJECT_SIGNAL_INFO) if gdbarch methods for the requested data
aren't present. Return with TARGET_XFER_E_IO if the gdbarch method
isn't present instead.
Diff:
---
gdb/corelow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/corelow.c b/gdb/corelow.c
index 1579e6bc2b8..001c4f147fc 100644
--- a/gdb/corelow.c
+++ b/gdb/corelow.c
@@ -943,7 +943,7 @@ core_target::xfer_partial (enum target_object object, const char *annex,
return TARGET_XFER_OK;
}
}
- /* FALL THROUGH */
+ return TARGET_XFER_E_IO;
case TARGET_OBJECT_LIBRARIES_AIX:
if (m_core_gdbarch != nullptr
@@ -964,7 +964,7 @@ core_target::xfer_partial (enum target_object object, const char *annex,
return TARGET_XFER_OK;
}
}
- /* FALL THROUGH */
+ return TARGET_XFER_E_IO;
case TARGET_OBJECT_SIGNAL_INFO:
if (readbuf)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-17 16:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 16:38 [binutils-gdb] Remove fall throughs in core_target::xfer_partial John Baldwin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).