public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Felix Willgerodt <fwillger@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb, btrace: Throw an error for empty recordings when replaying starts.
Date: Tue, 17 May 2022 10:43:53 +0000 (GMT)	[thread overview]
Message-ID: <20220517104353.8B4DA3858C51@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=49a73ab9d345e1cd412a93b34a0b8c166603d80e

commit 49a73ab9d345e1cd412a93b34a0b8c166603d80e
Author: Felix Willgerodt <felix.willgerodt@intel.com>
Date:   Mon May 9 10:12:39 2022 +0200

    gdb, btrace: Throw an error for empty recordings when replaying starts.
    
    This makes record_btrace_start_replaying() more consistent, as it already
    errors out e.g. on a recording with only gaps.

Diff:
---
 gdb/record-btrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 373d82b8b99..3f8a69dd04f 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -2017,7 +2017,7 @@ record_btrace_start_replaying (struct thread_info *tp)
 
   /* We can't start replaying without trace.  */
   if (btinfo->functions.empty ())
-    return NULL;
+    error (_("No trace."));
 
   /* GDB stores the current frame_id when stepping in order to detects steps
      into subroutines.


                 reply	other threads:[~2022-05-17 10:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517104353.8B4DA3858C51@sourceware.org \
    --to=fwillger@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).