public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] ranged_breakpoint: don't use init_raw_breakpoint
@ 2022-05-20 19:42 Pedro Alves
  0 siblings, 0 replies; only message in thread
From: Pedro Alves @ 2022-05-20 19:42 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f317d1eb2a7a7b9ec724630a7d70b51f435ff116

commit f317d1eb2a7a7b9ec724630a7d70b51f435ff116
Author: Pedro Alves <pedro@palves.net>
Date:   Fri May 6 22:21:36 2022 +0100

    ranged_breakpoint: don't use init_raw_breakpoint
    
    ranged_breakpoint's ctor already sets the breakpoint's type to
    bp_hardware_breakpoint.
    
    Since this is a "regular" breakpoint, b->pspace should remain NULL.
    
    Thus, the only thing init_raw_breakpoint is needed for, is to add the
    breakpoint's location.  Do that directly.
    
    Change-Id: I1505de94c3919881c2b300437e2c0da9b05f76bd

Diff:
---
 gdb/breakpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 8f6794511e7..f9332e1f998 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -9439,7 +9439,7 @@ break_range_command (const char *arg, int from_tty)
 
   /* Now set up the breakpoint.  */
   std::unique_ptr<breakpoint> br (new ranged_breakpoint (get_current_arch ()));
-  init_raw_breakpoint (br.get (), sal_start, bp_hardware_breakpoint);
+  br->add_location (sal_start);
   b = add_to_breakpoint_chain (std::move (br));
 
   set_breakpoint_count (breakpoint_count + 1);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-20 19:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-20 19:42 [binutils-gdb] ranged_breakpoint: don't use init_raw_breakpoint Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).