[binutils-gdb] Make exception_catchpoint inherit base_breakpoint instead of catchpoint

[binutils-gdb] Make exception_catchpoint inherit base_breakpoint instead of catchpoint

[Pedro Alves]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=249dfeafc96db9d36ea8c22f0ae3c3eb5b76b5ba

commit 249dfeafc96db9d36ea8c22f0ae3c3eb5b76b5ba
Author: Pedro Alves <pedro@palves.net>
Date:   Sat May 7 01:18:34 2022 +0100

    Make exception_catchpoint inherit base_breakpoint instead of catchpoint
    
    exception_catchpoint is really a code breakpoint, with locations set
    by sals, re-set like other code breakpoints, etc., so make it inherit
    base_breakpoint.
    
    This adds a bit of duplicated code to exception_catchpoint's ctor
    (copied from struct catchpoint's ctor), but it will be eliminated in a
    following patch.
    
    Change-Id: I9fbb2927491120e9744a4f5e5cb5e6870ca07009

Diff:
---
 gdb/break-catch-throw.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c
index f15fa531519..90fc3e6d325 100644
--- a/gdb/break-catch-throw.c
+++ b/gdb/break-catch-throw.c
@@ -63,15 +63,17 @@ static const struct exception_names exception_functions[] =
   { "-probe-stap libstdcxx:catch", "__cxa_begin_catch" }
 };
 
-/* The type of an exception catchpoint.  */
+/* The type of an exception catchpoint.  Unlike most catchpoints, this
+   one is implemented with code breakpoints, so it inherits struct
+   base_breakpoint, not struct catchpoint.  */
 
-struct exception_catchpoint : public catchpoint
+struct exception_catchpoint : public base_breakpoint
 {
   exception_catchpoint (struct gdbarch *gdbarch,
-			bool temp, const char *cond_string,
+			bool temp, const char *cond_string_,
 			enum exception_event_kind kind_,
 			std::string &&except_rx)
-    : catchpoint (gdbarch, temp, cond_string),
+    : base_breakpoint (gdbarch, bp_catchpoint),
       kind (kind_),
       exception_rx (std::move (except_rx)),
       pattern (exception_rx.empty ()
@@ -79,6 +81,12 @@ struct exception_catchpoint : public catchpoint
 	       : new compiled_regex (exception_rx.c_str (), REG_NOSUB,
 				     _("invalid type-matching regexp")))
   {
+    if (cond_string_ != nullptr)
+      cond_string = make_unique_xstrdup (cond_string_);
+    disposition = temp ? disp_del : disp_donttouch;
+
+    pspace = current_program_space;
+    re_set ();
   }
 
   void re_set () override;
@@ -375,8 +383,6 @@ handle_gnu_v3_exceptions (int tempflag, std::string &&except_rx,
     (new exception_catchpoint (gdbarch, tempflag, cond_string,
 			       ex_event, std::move (except_rx)));
 
-  cp->re_set ();
-
   install_breakpoint (0, std::move (cp), 1);
 }