public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Pedro Alves <palves@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Momentary breakpoints should have no breakpoint number Date: Fri, 20 May 2022 19:44:04 +0000 (GMT) [thread overview] Message-ID: <20220520194404.BC0DF3856DEA@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f9703051465a03bace3cc17b80fcd12c19a60821 commit f9703051465a03bace3cc17b80fcd12c19a60821 Author: Pedro Alves <pedro@palves.net> Date: Thu May 12 21:04:42 2022 +0100 Momentary breakpoints should have no breakpoint number Momentary breakpoints have no breakpoint number, their breakpoint number should be always 0, to avoid constantly incrementing (or decrementing) the internal breakpoint count. Indeed, set_momentary_breakpoint installs the created breakpoint without a number. However, momentary_breakpoint_from_master incorrectly gives an internal breakpoint number to the new breakpoint. This commit fixes that. Change-Id: Iedcae5432cdf232db9e9a6e1a646d358abd34f95 Diff: --- gdb/breakpoint.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 0c3946cbc36..9006311b4bf 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -7945,7 +7945,6 @@ momentary_breakpoint_from_master (struct breakpoint *orig, copy->enable_state = bp_enabled; copy->disposition = disp_donttouch; - copy->number = internal_breakpoint_number--; breakpoint *b = add_to_breakpoint_chain (std::move (copy)); update_global_location_list_nothrow (UGLL_DONT_INSERT);
reply other threads:[~2022-05-20 19:44 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220520194404.BC0DF3856DEA@sourceware.org \ --to=palves@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).