[binutils-gdb] Momentary breakpoints should have no breakpoint number

[binutils-gdb] Momentary breakpoints should have no breakpoint number

[Pedro Alves]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f9703051465a03bace3cc17b80fcd12c19a60821

commit f9703051465a03bace3cc17b80fcd12c19a60821
Author: Pedro Alves <pedro@palves.net>
Date:   Thu May 12 21:04:42 2022 +0100

    Momentary breakpoints should have no breakpoint number
    
    Momentary breakpoints have no breakpoint number, their breakpoint
    number should be always 0, to avoid constantly incrementing (or
    decrementing) the internal breakpoint count.
    
    Indeed, set_momentary_breakpoint installs the created breakpoint
    without a number.
    
    However, momentary_breakpoint_from_master incorrectly gives an
    internal breakpoint number to the new breakpoint.  This commit fixes
    that.
    
    Change-Id: Iedcae5432cdf232db9e9a6e1a646d358abd34f95

Diff:
---
 gdb/breakpoint.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 0c3946cbc36..9006311b4bf 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7945,7 +7945,6 @@ momentary_breakpoint_from_master (struct breakpoint *orig,
 
   copy->enable_state = bp_enabled;
   copy->disposition = disp_donttouch;
-  copy->number = internal_breakpoint_number--;
 
   breakpoint *b = add_to_breakpoint_chain (std::move (copy));
   update_global_location_list_nothrow (UGLL_DONT_INSERT);