public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.reverse/test_ioctl_TCSETSW.exp with libc debuginfo
Date: Mon, 13 Jun 2022 22:26:50 +0000 (GMT)	[thread overview]
Message-ID: <20220613222650.6274D3858286@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c2ac533e98438df5e5c2c58cce104c927ad42d09

commit c2ac533e98438df5e5c2c58cce104c927ad42d09
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Jun 14 00:26:46 2022 +0200

    [gdb/testsuite] Fix gdb.reverse/test_ioctl_TCSETSW.exp with libc debuginfo
    
    When running test-case gdb.reverse/test_ioctl_TCSETSW.exp with glibc debuginfo
    installed, I run into:
    ...
    (gdb) PASS: gdb.reverse/test_ioctl_TCSETSW.exp: at TCSETSW call
    step^M
    __tcsetattr (fd=0, optional_actions=1, termios_p=0x7fffffffcf50) at \
      ../sysdeps/unix/sysv/linux/tcsetattr.c:45^M
    45      {^M
    (gdb) FAIL: gdb.reverse/test_ioctl_TCSETSW.exp: handle TCSETSW
    ...
    
    The problem is that the step is expected to step over the call to tcsetattr,
    but due to glibc debuginfo being installed, we step into the call.
    
    Fix this by using next instead of step.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp b/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp
index 86a62ebe5e5..4a81a618efc 100644
--- a/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp
+++ b/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp
@@ -35,7 +35,7 @@ gdb_test "break $stop" ".*Breakpoint .*" "stop at TCSETSW"
 gdb_test "continue"  ".*Breakpoint .*" "at TCSETSW call"
 
 set test "handle TCSETSW"
-gdb_test_multiple "step"  $test {
+gdb_test_multiple "next"  $test {
     -re "Process record and replay target doesn't support ioctl request 0x.*$gdb_prompt $" {
 	fail $test
     }


                 reply	other threads:[~2022-06-13 22:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613222650.6274D3858286@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).