public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Pedro Alves <palves@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Delete delete_thread_silent Date: Fri, 24 Jun 2022 10:25:53 +0000 (GMT) [thread overview] Message-ID: <20220624102553.3C33E385742C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=39b8a8090ed7e8967ceca3655aa5f3a2ae91219d commit 39b8a8090ed7e8967ceca3655aa5f3a2ae91219d Author: Pedro Alves <pedro@palves.net> Date: Wed Jun 22 18:20:42 2022 +0100 Delete delete_thread_silent delete_thread_silent is no longer used anywhere. Delete it. Change-Id: Iafcec12339861d5ab2e29c14d7b1f884c9e11c0f Diff: --- gdb/gdbthread.h | 4 ---- gdb/thread.c | 28 +++++----------------------- 2 files changed, 5 insertions(+), 27 deletions(-) diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h index 1a33eb61221..1f17ad7d9e7 100644 --- a/gdb/gdbthread.h +++ b/gdb/gdbthread.h @@ -623,10 +623,6 @@ extern struct thread_info *add_thread_with_info (process_stratum_target *targ, as exited and do the notification. */ extern void delete_thread (struct thread_info *thread); -/* Like delete_thread, but be quiet about it. Used when the process - this thread belonged to has already exited, for example. */ -extern void delete_thread_silent (struct thread_info *thread); - /* Mark the thread exited, but don't delete it or remove it from the inferior thread list. */ extern void set_thread_exited (thread_info *tp, bool silent); diff --git a/gdb/thread.c b/gdb/thread.c index 378c5ee2d13..f0ad82e76d7 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -450,20 +450,16 @@ global_thread_step_over_chain_remove (struct thread_info *tp) global_thread_step_over_list.erase (it); } -/* Delete the thread referenced by THR. If SILENT, don't notify - the observer of this exit. - - THR must not be NULL or a failed assertion will be raised. */ +/* See gdbthread.h. */ -static void -delete_thread_1 (thread_info *thr, bool silent) +void +delete_thread (thread_info *thr) { gdb_assert (thr != nullptr); - threads_debug_printf ("deleting thread %s, silent = %d", - thr->ptid.to_string ().c_str (), silent); + threads_debug_printf ("deleting thread %s", thr->ptid.to_string ().c_str ()); - set_thread_exited (thr, silent); + set_thread_exited (thr, false); if (!thr->deletable ()) { @@ -477,20 +473,6 @@ delete_thread_1 (thread_info *thr, bool silent) delete thr; } -/* See gdbthread.h. */ - -void -delete_thread (thread_info *thread) -{ - delete_thread_1 (thread, false /* not silent */); -} - -void -delete_thread_silent (thread_info *thread) -{ - delete_thread_1 (thread, true /* silent */); -} - struct thread_info * find_thread_global_id (int global_id) {
reply other threads:[~2022-06-24 10:25 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220624102553.3C33E385742C@sourceware.org \ --to=palves@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).