public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Carl Love <carll@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Fix for gdb.base/stap-probe.c
Date: Wed, 13 Jul 2022 15:33:30 +0000 (GMT)	[thread overview]
Message-ID: <20220713153330.D4342384F01E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2b8b0dca3b6b9ad40e0c11754bf2f972bd8de890

commit 2b8b0dca3b6b9ad40e0c11754bf2f972bd8de890
Author: Carl Love <cel@us.ibm.com>
Date:   Wed Jul 13 15:30:43 2022 +0000

    Fix for gdb.base/stap-probe.c
    
    On PowePC, the test fails on a compile error:
    
      /../binutils-gdb-current/gdb/testsuite/gdb.base/stap-probe.c:107:1: error: expected '=', ',', ';', 'asm' or 'attribute' before 'use_xmm_reg'
      107 | use_xmm_reg (int val)
      | ^~~~~~~~~~~
    
    Where the source code for stap-probe.c is:
    
      static const char * __attribute__((noinline)) ATTRIBUTE_NOCLONE
      use_xmm_reg (int val)                         <-- line 107
      {
      ...
    
    The issue is the ATTRIBUTE_NOCLONE is not defined as an attribute as
    expected.  The #define for ATTRIBUTE_NOCLONE can be found in
    ../lib/attributes.h.
    
    This patch adds the missing include statement for the definition of
    ATTRIBUTE_NOCLONE.
    
    The patch has been tested and verified on a Power10 system.

Diff:
---
 gdb/testsuite/gdb.base/stap-probe.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/testsuite/gdb.base/stap-probe.c b/gdb/testsuite/gdb.base/stap-probe.c
index d1482c35caf..527f7e187eb 100644
--- a/gdb/testsuite/gdb.base/stap-probe.c
+++ b/gdb/testsuite/gdb.base/stap-probe.c
@@ -15,6 +15,8 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#include "../lib/attributes.h"
+
 #if USE_SEMAPHORES
 
 #define _SDT_HAS_SEMAPHORES


                 reply	other threads:[~2022-07-13 15:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713153330.D4342384F01E@sourceware.org \
    --to=carll@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).