public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix for gdb.base/stap-probe.c
@ 2022-07-13 15:33 Carl Love
0 siblings, 0 replies; only message in thread
From: Carl Love @ 2022-07-13 15:33 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2b8b0dca3b6b9ad40e0c11754bf2f972bd8de890
commit 2b8b0dca3b6b9ad40e0c11754bf2f972bd8de890
Author: Carl Love <cel@us.ibm.com>
Date: Wed Jul 13 15:30:43 2022 +0000
Fix for gdb.base/stap-probe.c
On PowePC, the test fails on a compile error:
/../binutils-gdb-current/gdb/testsuite/gdb.base/stap-probe.c:107:1: error: expected '=', ',', ';', 'asm' or 'attribute' before 'use_xmm_reg'
107 | use_xmm_reg (int val)
| ^~~~~~~~~~~
Where the source code for stap-probe.c is:
static const char * __attribute__((noinline)) ATTRIBUTE_NOCLONE
use_xmm_reg (int val) <-- line 107
{
...
The issue is the ATTRIBUTE_NOCLONE is not defined as an attribute as
expected. The #define for ATTRIBUTE_NOCLONE can be found in
../lib/attributes.h.
This patch adds the missing include statement for the definition of
ATTRIBUTE_NOCLONE.
The patch has been tested and verified on a Power10 system.
Diff:
---
gdb/testsuite/gdb.base/stap-probe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/testsuite/gdb.base/stap-probe.c b/gdb/testsuite/gdb.base/stap-probe.c
index d1482c35caf..527f7e187eb 100644
--- a/gdb/testsuite/gdb.base/stap-probe.c
+++ b/gdb/testsuite/gdb.base/stap-probe.c
@@ -15,6 +15,8 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include "../lib/attributes.h"
+
#if USE_SEMAPHORES
#define _SDT_HAS_SEMAPHORES
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-13 15:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 15:33 [binutils-gdb] Fix for gdb.base/stap-probe.c Carl Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).