public inbox for
help / color / mirror / Atom feed
From: Aaron Merey <>
Subject: [binutils-gdb] gdb-add-index always generates an error when libdebuginfod wasn't compiled in
Date: Fri, 15 Jul 2022 21:36:52 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=92b0a182fe00da3022516f3cb8f815d527d73652

commit 92b0a182fe00da3022516f3cb8f815d527d73652
Author: Aaron Merey <>
Date:   Tue Jul 5 18:11:49 2022 -0400

    gdb-add-index always generates an error when libdebuginfod wasn't compiled in
    gdb-add-index runs gdb with -iex 'set debuginfod enabled off'.  If gdb
    is not compiled against libdebuginfod this causes an unnecessary error
    message to be printed to stderr indicating that gdb was not built with
    debuginfod support.
    Fix this by changing the 'set debuginfod enabled off' command to a
    no-op when gdb isn't built with libdebuginfod.

 gdb/debuginfod-support.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index 9dbe6b5d8b2..5f04a2b38ca 100644
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -368,7 +368,9 @@ set_debuginfod_enabled (const char *value)
   debuginfod_enabled = value;
-  error (NO_IMPL);
+  /* Disabling debuginfod when gdb is not built with it is a no-op.  */
+  if (value != debuginfod_off)
+    error (NO_IMPL);

                 reply	other threads:[~2022-07-15 21:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).