public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Carl Love <carll@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp Date: Wed, 12 Oct 2022 20:59:25 +0000 (GMT) [thread overview] Message-ID: <20221012205925.2D1C53858D38@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e610d38f83248ba2cbea4d8735c3f7ee5953a38b commit e610d38f83248ba2cbea4d8735c3f7ee5953a38b Author: Carl Love <cel@us.ibm.com> Date: Wed Oct 12 16:58:25 2022 -0400 PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp Test gdb.base/watchpoint-stops-at-right-insn.exp generates 4 test errors on Power 9. The test uses the test [target_info exists gdb, no_hardware_watchpoints] to determine if the processor supports hardware watchpoints. The check only examines the processor type to determine if it supports hardware watchpoints. Note, the test works fine on Power 10. The PowerPC processors support hardware watchpoints with the exception of Power 9. The hardware watchpoint support is disabled on Power 9. The test skip_hw_watchpoint_tests must be used to correctly determine if the PowerPC processor supports hardware watchpoints. This patch replaces the [target_info exists gdb,no_hardware_watchpoints] with the skip_hw_watchpoint_tests_p check. With the patch, the test is disabled on Power 9 but runs on all other PowerPC processors. The patch has been tested on Power 9, Power 10 and X86-64 with no regression failures. Diff: --- gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp index f9adb1f4f91..6c445d4cbd8 100644 --- a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp +++ b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp @@ -71,7 +71,7 @@ standard_testfile # No use testing this if we can't use hardware watchpoints. -if {[target_info exists gdb,no_hardware_watchpoints]} { +if {[skip_hw_watchpoint_tests]} { return -1 }
reply other threads:[~2022-10-12 20:59 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221012205925.2D1C53858D38@sourceware.org \ --to=carll@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).