public inbox for
help / color / mirror / Atom feed
* [binutils-gdb] PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp
@ 2022-10-12 20:59 Carl Love
  0 siblings, 0 replies; only message in thread
From: Carl Love @ 2022-10-12 20:59 UTC (permalink / raw)
  To: gdb-cvs;h=e610d38f83248ba2cbea4d8735c3f7ee5953a38b

commit e610d38f83248ba2cbea4d8735c3f7ee5953a38b
Author: Carl Love <>
Date:   Wed Oct 12 16:58:25 2022 -0400

    PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp
    Test gdb.base/watchpoint-stops-at-right-insn.exp generates 4 test errors
    on Power 9.  The test uses the test [target_info exists gdb,
    no_hardware_watchpoints] to determine if the processor supports hardware
    watchpoints.  The check only examines the processor type to determine if
    it supports hardware watchpoints.  Note, the test works fine on Power 10.
    The PowerPC processors support hardware watchpoints with the
    exception of Power 9. The hardware watchpoint support is disabled on
    Power 9.  The test skip_hw_watchpoint_tests must be used to correctly
    determine if the PowerPC processor supports hardware watchpoints.
    This patch replaces the [target_info exists gdb,no_hardware_watchpoints]
    with the skip_hw_watchpoint_tests_p check.  With the patch, the test is
    disabled on Power 9 but runs on all other PowerPC processors.
    The patch has been tested on Power 9, Power 10 and X86-64 with no
    regression failures.

 gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp
index f9adb1f4f91..6c445d4cbd8 100644
--- a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp
+++ b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp
@@ -71,7 +71,7 @@
 # No use testing this if we can't use hardware watchpoints.
-if {[target_info exists gdb,no_hardware_watchpoints]} {
+if {[skip_hw_watchpoint_tests]} {
     return -1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-12 20:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 20:59 [binutils-gdb] PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp Carl Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).