public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: copyright: make file header scan a bit more pythonic
@ 2022-10-26 10:11 Michael Frysinger
0 siblings, 0 replies; only message in thread
From: Michael Frysinger @ 2022-10-26 10:11 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=99033a63c7ba0997ef737392eef15337d6783078
commit 99033a63c7ba0997ef737392eef15337d6783078
Author: Mike Frysinger <vapier@gentoo.org>
Date: Sat Jan 1 13:08:20 2022 -0500
gdb: copyright: make file header scan a bit more pythonic
Should be functionally the same, but uses more pythonic idioms to get
fewer lines of code, and to make sure to not leak open file handles.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diff:
---
gdb/copyright.py | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/gdb/copyright.py b/gdb/copyright.py
index 8d623e6f5c7..040fed18708 100755
--- a/gdb/copyright.py
+++ b/gdb/copyright.py
@@ -148,15 +148,12 @@ def may_have_copyright_notice(filename):
# so just open the file as a byte stream. We only need to search
# for a pattern that should be the same regardless of encoding,
# so that should be good enough.
- fd = open(filename, "rb")
-
- lineno = 1
- for line in fd:
- if b"Copyright" in line:
- return True
- lineno += 1
- if lineno > 50:
- return False
+ with open(filename, "rb") as fd:
+ for lineno, line in enumerate(fd, start=1):
+ if b"Copyright" in line:
+ return True
+ if lineno > MAX_LINES:
+ break
return False
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-26 10:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 10:11 [binutils-gdb] gdb: copyright: make file header scan a bit more pythonic Michael Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).