public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Remove address from test names
Date: Thu, 27 Oct 2022 15:14:38 +0000 (GMT)	[thread overview]
Message-ID: <20221027151439.7A6A33851533@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=48ca5676924d2609f1b9ea1990719c9eb41e88a2

commit 48ca5676924d2609f1b9ea1990719c9eb41e88a2
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Oct 27 17:14:33 2022 +0200

    [gdb/testsuite] Remove address from test names
    
    I noticed an address in a test name:
    ...
    PASS: gdb.base/eh_return.exp: gdb_breakpoint: \
      set breakpoint at *0x000000000040071b
    ...
    
    Stabilize the test name by using "set breakpoint on address" instead.
    
    Likewise in two other test-cases.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.base/eh_return.exp         | 2 +-
 gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp | 2 +-
 gdb/testsuite/gdb.opt/inline-break.exp       | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.base/eh_return.exp b/gdb/testsuite/gdb.base/eh_return.exp
index 6e4b9bd0bba..a6dda78e013 100644
--- a/gdb/testsuite/gdb.base/eh_return.exp
+++ b/gdb/testsuite/gdb.base/eh_return.exp
@@ -73,7 +73,7 @@ if { $address == -1 } {
 
 clean_restart ${binfile}
 
-gdb_breakpoint "*$address" message
+gdb_assert [gdb_breakpoint "*$address" no-message] "set breakpoint on address"
 
 # The assert did not reproduce when running to main, and continuing to the
 # breakpoint, so instead, run to the breakpoint.
diff --git a/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp b/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp
index 17537585ad2..2e479d6ebe2 100644
--- a/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp
+++ b/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp
@@ -45,7 +45,7 @@ if { $next_insn_addr == "" } {
     return -1
 }
 
-gdb_test "b *$next_insn_addr" "Breakpoint .*"
+gdb_test "b *$next_insn_addr" "Breakpoint .*" "set breakpoint on address"
 
 # So that GDB doesn't try to remove the regular breakpoint when the
 # step finishes.
diff --git a/gdb/testsuite/gdb.opt/inline-break.exp b/gdb/testsuite/gdb.opt/inline-break.exp
index 24dd6ebaf0a..708fd74aa1e 100644
--- a/gdb/testsuite/gdb.opt/inline-break.exp
+++ b/gdb/testsuite/gdb.opt/inline-break.exp
@@ -292,7 +292,9 @@ with_test_prefix "address" {
 
     # Set the breakpoint by address, and check that GDB reports the
     # breakpoint location being the inline function.
-    gdb_test "break *$address" ".*Breakpoint .* at $address: file .*$srcfile, line $line."
+    gdb_test "break *$address" \
+	".*Breakpoint .* at $address: file .*$srcfile, line $line." \
+	"set breakpoint on address"
 
     gdb_test "info break \$bpnum" "in func1 at .*$srcfile:$line"

                 reply	other threads:[~2022-10-27 15:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027151439.7A6A33851533@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).