public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Consume output asap in gdb.server/multi-ui-errors.exp
@ 2022-10-29  7:43 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-10-29  7:43 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=64ba0c58a79bdec307b722cc09aab724d34ba28b

commit 64ba0c58a79bdec307b722cc09aab724d34ba28b
Author: Tom de Vries <tdevries@suse.de>
Date:   Sat Oct 29 09:43:32 2022 +0200

    [gdb/testsuite] Consume output asap in gdb.server/multi-ui-errors.exp
    
    With test-case gdb.server/multi-ui-errors.exp we see:
    ...
    (gdb) PASS: multi-ui-errors.exp: main UI, prompt after gdbserver dies
    continue^M
    Continuing.^M
    echo^M
    (gdb) PASS: multi-ui-errors.exp: extra UI, prompt after gdbserver dies
    ...
    
    The continue is issued earlier in the test-case, but the output has not been
    consumed, which makes it show up much later.
    
    Consume the continue output asap, to make it clear when the continue is issued:
    ...
    (gdb) PASS: gdb.server/multi-ui-errors.exp: connect to gdbserver
    continue^M
    Continuing.^M
    PASS: gdb.server/multi-ui-errors.exp: continue - extra UI
    ...
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.server/multi-ui-errors.exp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.server/multi-ui-errors.exp b/gdb/testsuite/gdb.server/multi-ui-errors.exp
index d3ddd0f2d08..8a1276fb272 100644
--- a/gdb/testsuite/gdb.server/multi-ui-errors.exp
+++ b/gdb/testsuite/gdb.server/multi-ui-errors.exp
@@ -75,7 +75,13 @@ with_spawn_id $extra_spawn_id {
 with_spawn_id $extra_spawn_id {
     gdb_test "target $gdbserver_protocol $gdbserver_gdbport" ".*" \
 	"connect to gdbserver"
-    send_gdb "continue\n"
+
+    # Issue a continue and consume the response.  Don't expect a prompt.
+    gdb_test_multiple "continue" "continue - extra UI" {
+	-re  "\r\nContinuing\.\r\n" {
+	    pass $gdb_test_name
+	}
+    }
 }
 
 # We're going to kill the gdbserver, but before we do, lets make sure

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-29  7:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-29  7:43 [binutils-gdb] [gdb/testsuite] Consume output asap in gdb.server/multi-ui-errors.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).