public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] sim: erc32: link sis to run program
@ 2022-11-03 18:37 Michael Frysinger
  0 siblings, 0 replies; only message in thread
From: Michael Frysinger @ 2022-11-03 18:37 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fa71c76d475f40cc583fb496d262c7bfa5a040fe

commit fa71c76d475f40cc583fb496d262c7bfa5a040fe
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Fri Nov 4 00:25:32 2022 +0700

    sim: erc32: link sis to run program
    
    The erc32 sim does a lot itself, including handling of the CLI.  It
    used to provide a run-compatible interface in the pre-nrun days, but
    it was dropped when the old run interface was punted.  Since the old
    commit 465fb143c87076b6416a8d0d5dd79bb016060fe3 ("sim: make nrun the
    default run program"), the erc32 run & sis programs have been the
    same, and erc32 hasn't provide a real run-compatible interface.
    
    Simplify this by linking the two programs via ln/cp instead of running
    the linking phase twice to produce the same result.  If/when we fix up
    the erc32 port to have a proper run interface, it should be easy to
    split these back apart into real programs.
    
    Note: the interf.o reference in here is a bit of a misdirect.  Since
    that object is placed into libsim.a, it's never been linked into the
    programs since the linker ignores objects that aren't referenced, and
    only gdb uses those symbols.

Diff:
---
 sim/erc32/Makefile.in | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/sim/erc32/Makefile.in b/sim/erc32/Makefile.in
index 41830aab726..013b604be49 100644
--- a/sim/erc32/Makefile.in
+++ b/sim/erc32/Makefile.in
@@ -34,13 +34,10 @@ SIM_EXTRA_CFLAGS += -DFAST_UART -I$(srcroot)
 
 ## COMMON_POST_CONFIG_FRAG
 
-# `sis' doesn't need interf.o.
-SIS_OFILES = exec.o erc32.o func.o help.o float.o
-
 all: sis$(EXEEXT)
-sis$(EXEEXT): sis.o $(SIS_OFILES) libsim.a $(LIBDEPS)
-	$(ECHO_CCLD) $(CC) $(ALL_CFLAGS) -o sis$(EXEEXT) \
-	  sis.o $(SIS_OFILES) libsim.a $(EXTRA_LIBS)
+sis$(EXEEXT): run$(EXEEXT)
+	$(SILENCE) rm -f $@
+	$(ECHO_GEN) ln $< $@ 2>/dev/null || $(LN_S) $< $@ 2>/dev/null || cp -p $< $@
 
 # Copy the files into directories where they will be run.
 install-sis: installdirs

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-03 18:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 18:37 [binutils-gdb] sim: erc32: link sis to run program Michael Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).