[binutils-gdb] sim: igen: add missing newline to various error messages

[binutils-gdb] sim: igen: add missing newline to various error messages

[Michael Frysinger]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3abad2f6a637a0c56af70311d94ec66eea1b4852

commit 3abad2f6a637a0c56af70311d94ec66eea1b4852
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Thu Nov 10 00:29:27 2022 +0700

    sim: igen: add missing newline to various error messages
    
    The error() function expects a trailing newline in its message.
    Most callers do this already, so adding it to the few that don't.

Diff:
---
 sim/igen/gen-support.c | 2 +-
 sim/igen/gen.c         | 2 +-
 sim/igen/ld-insn.c     | 2 +-
 sim/igen/misc.c        | 2 +-
 sim/igen/misc.h        | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/sim/igen/gen-support.c b/sim/igen/gen-support.c
index de5a507753a..d9d0f7c09a6 100644
--- a/sim/igen/gen-support.c
+++ b/sim/igen/gen-support.c
@@ -180,7 +180,7 @@ support_c_function (lf *file, function_entry * function, void *data)
   lf_printf (file, "{\n");
   lf_indent (file, +2);
   if (function->code == NULL)
-    error (function->line, "Function without body (or null statement)");
+    error (function->line, "Function without body (or null statement)\n");
   lf_print__line_ref (file, function->code->line);
   table_print_code (file, function->code);
   if (function->is_internal)
diff --git a/sim/igen/gen.c b/sim/igen/gen.c
index d2a40d194b0..3882b5bd34a 100644
--- a/sim/igen/gen.c
+++ b/sim/igen/gen.c
@@ -987,7 +987,7 @@ gen_entry_expand_opcode (gen_entry *table,
 				}
 			      if (bit == NULL && t == NULL)
 				error (instruction->line,
-				       "Conditional `%s' of field `%s' isn't expanded",
+				       "Conditional `%s' of field `%s' isn't expanded\n",
 				       condition->string, field->val_string);
 			      switch (condition->test)
 				{
diff --git a/sim/igen/ld-insn.c b/sim/igen/ld-insn.c
index 20c1f77b33f..435bf483efd 100644
--- a/sim/igen/ld-insn.c
+++ b/sim/igen/ld-insn.c
@@ -914,7 +914,7 @@ static table_entry *
 parse_macro_record (table *file, table_entry *record)
 {
 #if 1
-  error (record->line, "Macros are not implemented");
+  error (record->line, "Macros are not implemented\n");
 #else
   /* parse the define record */
   if (record->nr_fields < nr_define_fields)
diff --git a/sim/igen/misc.c b/sim/igen/misc.c
index 598f886d7ae..c5c494bb6b5 100644
--- a/sim/igen/misc.c
+++ b/sim/igen/misc.c
@@ -246,7 +246,7 @@ name2i (const char *names, const name_map * map)
   if (curr->i >= 0)
     return curr->i;
   else
-    error (NULL, "%s contains no valid names", names);
+    error (NULL, "%s contains no valid names\n", names);
   return 0;
 }
 
diff --git a/sim/igen/misc.h b/sim/igen/misc.h
index a1cae768179..214505a761f 100644
--- a/sim/igen/misc.h
+++ b/sim/igen/misc.h
@@ -64,7 +64,7 @@ do { \
   line_ref line; \
   line.file_name = filter_filename (__FILE__); \
   line.line_nr = __LINE__; \
-  error (&line, EXPRESSION); \
+  error (&line, EXPRESSION "\n"); \
 } while (0)
 
 #define ASSERT(EXPRESSION) \
@@ -73,7 +73,7 @@ do { \
     line_ref line; \
     line.file_name = filter_filename (__FILE__); \
     line.line_nr = __LINE__; \
-    error(&line, "assertion failed - %s\n", #EXPRESSION); \
+    error (&line, "assertion failed - %s\n", #EXPRESSION); \
   } \
 } while (0)