[binutils-gdb] gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate

[binutils-gdb] gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate

[Simon Marchi]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=45eca9d9f36985672cb2303b4ea0b3c855961c1d

commit 45eca9d9f36985672cb2303b4ea0b3c855961c1d
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Mon Oct 24 16:16:09 2022 -0400

    gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate
    
    The assertion
    
        gdb_assert (m_cached_id != null_frame_id);
    
    is always true, as comparing equal to null_frame_id is always false
    (it's the first case in frame_id::operator==, not sure why it's not this
    way, but that's what it is).
    
    Replace the comparison with a call to frame_id_p.
    
    Approved-By: Tom Tromey <tom@tromey.com>
    Change-Id: I93986e6a85ac56353690792552e5b3b4cedec7fb

Diff:
---
 gdb/frame-info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/frame-info.c b/gdb/frame-info.c
index 84791205d90..584222dc490 100644
--- a/gdb/frame-info.c
+++ b/gdb/frame-info.c
@@ -39,7 +39,7 @@ frame_info_ptr::prepare_reinflate ()
 void
 frame_info_ptr::reinflate ()
 {
-  gdb_assert (m_cached_id != null_frame_id);
+  gdb_assert (frame_id_p (m_cached_id));
 
   if (m_ptr == nullptr)
     m_ptr = frame_find_by_id (m_cached_id).get ();