public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Drop apparently unneeded include of winsock2.h
Date: Sun, 13 Nov 2022 14:45:43 +0000 (GMT)	[thread overview]
Message-ID: <20221113144543.9CA173858284@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=90f902daf5edb817d57b5e377d7ad54948a5a9f4

commit 90f902daf5edb817d57b5e377d7ad54948a5a9f4
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Wed Nov 2 14:32:55 2022 +0000

    Drop apparently unneeded include of winsock2.h
    
    Commit d08bae3d ("Implement target async for Windows") unconditionally
    includes winsock2.h.  We don't want to do that on Cygwin, since
    including both winsock2.h and sys/select.h causes incompatible
    redefinition problems.
    
    Since that include is apparently unneeded, just drop it.
    
    Fixes: d08bae3d

Diff:
---
 gdb/windows-nat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index ab94de03bbf..6250cbc27a5 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -34,7 +34,6 @@
 #include <signal.h>
 #include <sys/types.h>
 #include <fcntl.h>
-#include <winsock2.h>
 #include <windows.h>
 #include <imagehlp.h>
 #ifdef __CYGWIN__

                 reply	other threads:[~2022-11-13 14:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221113144543.9CA173858284@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).