public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Drop apparently unneeded include of winsock2.h
@ 2022-11-13 14:45 Jon TURNEY
  0 siblings, 0 replies; only message in thread
From: Jon TURNEY @ 2022-11-13 14:45 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=90f902daf5edb817d57b5e377d7ad54948a5a9f4

commit 90f902daf5edb817d57b5e377d7ad54948a5a9f4
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Wed Nov 2 14:32:55 2022 +0000

    Drop apparently unneeded include of winsock2.h
    
    Commit d08bae3d ("Implement target async for Windows") unconditionally
    includes winsock2.h.  We don't want to do that on Cygwin, since
    including both winsock2.h and sys/select.h causes incompatible
    redefinition problems.
    
    Since that include is apparently unneeded, just drop it.
    
    Fixes: d08bae3d

Diff:
---
 gdb/windows-nat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index ab94de03bbf..6250cbc27a5 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -34,7 +34,6 @@
 #include <signal.h>
 #include <sys/types.h>
 #include <fcntl.h>
-#include <winsock2.h>
 #include <windows.h>
 #include <imagehlp.h>
 #ifdef __CYGWIN__

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2022-11-13 14:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-13 14:45 [binutils-gdb] Drop apparently unneeded include of winsock2.h Jon TURNEY

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).