public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testssuite] Skip aarch64 in skip_gdbserver_test if no xml support
Date: Tue, 15 Nov 2022 13:00:44 +0000 (GMT)	[thread overview]
Message-ID: <20221115130044.D7BD13894C20@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=08d237dd4ebdcc0a13cac1dc57cd73de067d2f98

commit 08d237dd4ebdcc0a13cac1dc57cd73de067d2f98
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Nov 15 14:00:41 2022 +0100

    [gdb/testssuite] Skip aarch64 in skip_gdbserver_test if no xml support
    
    On aarch64-linux, with a gdb build without libexpat, so without xml support, I
    run into:
    ...
    (gdb) builtin_spawn attach-no-multi-process^M
    attach 26808^M
    Attaching to Remote target^M
    warning: Can not parse XML target description; XML support was disabled at \
      compile time^M
    Reading symbols from attach-no-multi-process...^M
    Remote 'g' packet reply is too long (expected 788 bytes, got 796 bytes): ... ^M
    ...
    
    The test-case checks for skip_gdbserver_tests and that one contains a check
    for xml support:
    ...
        # If GDB is lack of XML support, and targets, like arm, have
        # multiple target descriptions, GDB doesn't know which target
        # description GDBserver uses, and may fail to parse 'g' packet
        # after connection.
        if { [gdb_skip_xml_test]
             && ([istarget "arm*-*-linux*"]
                  || [istarget "mips*-*-linux*"]
                  || [istarget "powerpc*-*-linux*"]
                  || [istarget "s390*-*-linux*"]
                  || [istarget "x86_64-*-linux*"]
                  || [istarget "i\[34567\]86-*-linux*"]) } {
            return 1
        }
    ...
    but it doesn't trigger because aarch64 is missing.
    
    Fix this by adding istarget "aarch64*-*-linux*".
    
    Tested on aarch64-linux.
    
    Approved-By: Luis Machado <luis.machado@arm.com>

Diff:
---
 gdb/testsuite/lib/gdbserver-support.exp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp
index 3f2cec246fa..c9f0c35c07e 100644
--- a/gdb/testsuite/lib/gdbserver-support.exp
+++ b/gdb/testsuite/lib/gdbserver-support.exp
@@ -173,6 +173,7 @@ proc skip_gdbserver_tests { } {
     # after connection.
     if { [gdb_skip_xml_test]
 	 && ([istarget "arm*-*-linux*"]
+	     || [istarget "aarch64*-*-linux*"]
 	     || [istarget "mips*-*-linux*"]
 	     || [istarget "powerpc*-*-linux*"]
 	     || [istarget "s390*-*-linux*"]

                 reply	other threads:[~2022-11-15 13:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221115130044.D7BD13894C20@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).