public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: don't avoid DWARF assembler tests with Clang Date: Fri, 18 Nov 2022 11:46:22 +0000 (GMT) [thread overview] Message-ID: <20221118114622.4A5ED3851892@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6911239bbaa7b4365d3d0ff7b6cb296cfe43480c commit 6911239bbaa7b4365d3d0ff7b6cb296cfe43480c Author: Andrew Burgess <aburgess@redhat.com> Date: Fri Nov 11 15:21:56 2022 +0000 gdb/testsuite: don't avoid DWARF assembler tests with Clang Two tests make the claim that the DWARF assembler requires gcc, however, this isn't true. I think at one point, when the DWARF assembler was first added, we did use some techniques that were not portable (see the comments in lib/dwarf.exp on function_range for details), however, I think most DWARF assembler tests will now work fine with Clang. The two tests that I modify in this commit both work fine with Clang, at least, I've tested with Clang 9.0.1 and 15.0.2, and don't see any problems, so I'm removing the early return logic that stops these tests from running with Clang. Reviewed-By: Lancelot SIX <lancelot.six@amd.com> Diff: --- gdb/testsuite/gdb.base/until-trailing-insns.exp | 6 ------ gdb/testsuite/gdb.cp/incomplete-type-overload.exp | 5 ----- 2 files changed, 11 deletions(-) diff --git a/gdb/testsuite/gdb.base/until-trailing-insns.exp b/gdb/testsuite/gdb.base/until-trailing-insns.exp index 6396b6650c1..56f6cf038e2 100644 --- a/gdb/testsuite/gdb.base/until-trailing-insns.exp +++ b/gdb/testsuite/gdb.base/until-trailing-insns.exp @@ -84,12 +84,6 @@ if {![dwarf2_support]} { return 0 } -# The DWARF assembler requires the gcc compiler. -if {![is_c_compiler_gcc]} { - unsupported "gcc is required for this test" - return 0 -} - standard_testfile .c .S if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { diff --git a/gdb/testsuite/gdb.cp/incomplete-type-overload.exp b/gdb/testsuite/gdb.cp/incomplete-type-overload.exp index 96ed25dd5d1..024014d68ba 100644 --- a/gdb/testsuite/gdb.cp/incomplete-type-overload.exp +++ b/gdb/testsuite/gdb.cp/incomplete-type-overload.exp @@ -31,11 +31,6 @@ if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}] { return } -if {[test_compiler_info clang-*-*]} { - untested "gcc is required for dwarf assembler tests" - return -} - if ![runto_main] { return }
reply other threads:[~2022-11-18 11:46 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221118114622.4A5ED3851892@sourceware.org \ --to=aburgess@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).