public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdbserver/linux: take condition out of callback in find_lwp_pid
@ 2022-11-18 16:09 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2022-11-18 16:09 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d4895ba2df3bbf38d64fce314f5933d05eb8990a

commit d4895ba2df3bbf38d64fce314f5933d05eb8990a
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Nov 18 11:09:11 2022 -0500

    gdbserver/linux: take condition out of callback in find_lwp_pid
    
    Just a small optimization, it's not necessary to recompute lwp at each
    iteration.
    
    While at it, change the variable type to long, as ptid_t::lwp returns a
    long.
    
    Reviewed-By: Andrew Burgess <aburgess@redhat.com>
    Change-Id: I181670ce1f90b59cb09ea4899367750be2ad9105

Diff:
---
 gdbserver/linux-low.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index 0cbfeb99086..a896b37528b 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -1731,9 +1731,9 @@ linux_process_target::status_pending_p_callback (thread_info *thread,
 struct lwp_info *
 find_lwp_pid (ptid_t ptid)
 {
-  thread_info *thread = find_thread ([&] (thread_info *thr_arg)
+  long lwp = ptid.lwp () != 0 ? ptid.lwp () : ptid.pid ();
+  thread_info *thread = find_thread ([lwp] (thread_info *thr_arg)
     {
-      int lwp = ptid.lwp () != 0 ? ptid.lwp () : ptid.pid ();
       return thr_arg->id.lwp () == lwp;
     });

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-18 16:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 16:09 [binutils-gdb] gdbserver/linux: take condition out of callback in find_lwp_pid Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).