public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: John Baldwin <jhb@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] fbsd-nat: Use regset supply/collect methods. Date: Tue, 22 Nov 2022 22:43:51 +0000 (GMT) [thread overview] Message-ID: <20221122224351.AA0F8385456F@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5dd6c79a323a9ca7bf8d5db3206532580365127e commit 5dd6c79a323a9ca7bf8d5db3206532580365127e Author: John Baldwin <jhb@FreeBSD.org> Date: Tue Nov 22 14:21:13 2022 -0800 fbsd-nat: Use regset supply/collect methods. fbsd-nat includes various helper routines for fetching and storing register sets via ptrace where the register set is described by a regset. These helper routines directly invoke the supply/collect_regset regcache methods which doesn't permit a regset to provide custom logic when fetching or storing a register set. Instead, just use the function pointers from the struct regset directly. Approved-By: Simon Marchi <simon.marchi@efficios.com> Diff: --- gdb/fbsd-nat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c index ad26503a2ad..7d279810483 100644 --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -1744,7 +1744,7 @@ fbsd_nat_target::fetch_register_set (struct regcache *regcache, int regnum, if (ptrace (fetch_op, pid, (PTRACE_TYPE_ARG3) regs, 0) == -1) perror_with_name (_("Couldn't get registers")); - regcache->supply_regset (regset, regnum, regs, size); + regset->supply_regset (regset, regcache, regnum, regs, size); return true; } return false; @@ -1768,7 +1768,7 @@ fbsd_nat_target::store_register_set (struct regcache *regcache, int regnum, if (ptrace (fetch_op, pid, (PTRACE_TYPE_ARG3) regs, 0) == -1) perror_with_name (_("Couldn't get registers")); - regcache->collect_regset (regset, regnum, regs, size); + regset->collect_regset (regset, regcache, regnum, regs, size); if (ptrace (store_op, pid, (PTRACE_TYPE_ARG3) regs, 0) == -1) perror_with_name (_("Couldn't write registers")); @@ -1813,7 +1813,7 @@ fbsd_nat_target::fetch_regset (struct regcache *regcache, int regnum, int note, if (ptrace (PT_GETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) == -1) perror_with_name (_("Couldn't get registers")); - regcache->supply_regset (regset, regnum, regs, size); + regset->supply_regset (regset, regcache, regnum, regs, size); return true; } return false; @@ -1838,7 +1838,7 @@ fbsd_nat_target::store_regset (struct regcache *regcache, int regnum, int note, if (ptrace (PT_GETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) == -1) perror_with_name (_("Couldn't get registers")); - regcache->collect_regset (regset, regnum, regs, size); + regset->collect_regset (regset, regcache, regnum, regs, size); if (ptrace (PT_SETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) == -1) perror_with_name (_("Couldn't write registers"));
reply other threads:[~2022-11-22 22:43 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221122224351.AA0F8385456F@sourceware.org \ --to=jhb@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).