public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib
@ 2022-11-24 15:23 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2022-11-24 15:23 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=45c4b4bc12ea1c81a72f3cd379d34b55cfc517ff
commit 45c4b4bc12ea1c81a72f3cd379d34b55cfc517ff
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Wed Nov 23 13:39:48 2022 -0500
gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib
Change-Id: I130e8914c2713095aab03e84aba1481b4c7af978
Approved-By: Kevin Buettner <kevinb@redhat.com>
Diff:
---
gdb/testsuite/gdb.base/break.exp | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp
index be349d9e7ea..a9728798fab 100644
--- a/gdb/testsuite/gdb.base/break.exp
+++ b/gdb/testsuite/gdb.base/break.exp
@@ -835,9 +835,6 @@ gdb_test_multiple "continue" \
}
}
-clean_restart breako2
-
-#
# test that 'rbreak' on a symbol that may be from a shared library doesn't
# cause a "Junk at end of arguments." error.
#
@@ -846,28 +843,31 @@ clean_restart breako2
# Note that this test won't necessarily choke on all targets even if
# all the rbreak issue is present. rbreak needs to match and set a
# breakpoint on a symbol causes 'break' to choke.
-#
-gdb_test_no_output "set breakpoint pending on" "rbreak junk pending setup"
+proc_with_prefix test_rbreak_shlib {} {
+ clean_restart breako2
-# We expect at least one breakpoint to be set when we "rbreak main".
-gdb_test "rbreak main" \
- ".*Breakpoint.*at.* file .*$srcfile, line.*" \
- "rbreak junk set breakpoint"
+ gdb_test_no_output "set breakpoint pending on" "rbreak junk pending setup"
-# Run to a breakpoint. Fail if we see "Junk at end of arguments".
-gdb_run_cmd
+ # We expect at least one breakpoint to be set when we "rbreak main".
+ gdb_test "rbreak main" \
+ ".*Breakpoint.*at.* file .*$::srcfile, line.*"
-set test "rbreak junk"
-gdb_test_multiple "" $test {
- -re "Junk at end of arguments" {
- fail $test
- }
- -re ".*Breakpoint \[0-9\]+,.*$gdb_prompt $" {
- pass $test
+ # Run to a breakpoint. Fail if we see "Junk at end of arguments".
+ gdb_run_cmd
+
+ gdb_test_multiple "" "rbreak junk" {
+ -re -wrap "Junk at end of arguments.*" {
+ fail $gdb_test_name
+ }
+ -re -wrap ".*Breakpoint \[0-9\]+,.*" {
+ pass $gdb_test_name
+ }
}
}
+test_rbreak_shlib
+
# Test break via convenience variable with file name
proc_with_prefix test_break_file_line_convenience_var {} {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-24 15:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 15:23 [binutils-gdb] gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).