public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix gdb.arch/altivec-regs.exp with gcc 4.8.5
@ 2022-11-28 12:57 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-11-28 12:57 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=85819864f7cbf813cde00cf3bed30a38414e1bd8

commit 85819864f7cbf813cde00cf3bed30a38414e1bd8
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Nov 28 13:57:17 2022 +0100

    [gdb/testsuite] Fix gdb.arch/altivec-regs.exp with gcc 4.8.5
    
    On powerpc64le-linux, using gcc 4.8.5, I run into:
    ...
    (gdb) PASS: gdb.arch/altivec-regs.exp: next (1)
    next^M
    11        c = vec_add (a, b);^M
    (gdb) PASS: gdb.arch/altivec-regs.exp: next (2)
    print/x a^M
    $67 = {0xfefefefe, 0xfefefefe, 0xfefefefe, 0xfefefefe}^M
    (gdb) FAIL: gdb.arch/altivec-regs.exp: print vector parameter a
    ...
    
    Looking at the disassembly and the debug info, it's clear why there's
    a FAIL.
    
    The debug info says that the variable can be found at some stack location, but
    the instructions don't seem to be writing there.
    
    We can work around this by marking variable a volatile.  Likewise for b.
    
    Note that marking the variables as volatile doesn't change the location
    information.
    
    Tested on power64le-linux.

Diff:
---
 gdb/testsuite/gdb.arch/altivec-regs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.arch/altivec-regs.c b/gdb/testsuite/gdb.arch/altivec-regs.c
index 4d4fe3f5dbb..8f3b729fe3f 100644
--- a/gdb/testsuite/gdb.arch/altivec-regs.c
+++ b/gdb/testsuite/gdb.arch/altivec-regs.c
@@ -2,7 +2,7 @@
 #include <stdio.h>
 
 vector unsigned int
-vector_fun (vector unsigned int a, vector unsigned int b)
+vector_fun (volatile vector unsigned int a, volatile vector unsigned int b)
 {
   vector unsigned int c;
   a = ((vector unsigned int) vec_splat_u8(2));

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-28 12:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 12:57 [binutils-gdb] [gdb/testsuite] Fix gdb.arch/altivec-regs.exp with gcc 4.8.5 Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).