public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/linux-nat: use l linux_nat_get_siginfo in linux_xfer_siginfo
@ 2022-12-05 21:39 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2022-12-05 21:39 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d29ea3286809466a0f490a39d3f6c72cf69bfa17

commit d29ea3286809466a0f490a39d3f6c72cf69bfa17
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Dec 2 15:09:24 2022 -0500

    gdb/linux-nat: use l linux_nat_get_siginfo in linux_xfer_siginfo
    
    I noticed we could reduce duplication a bit here.
    
    Change-Id: If24e54d1dac71b46f7c1f68a18a073d4c084b644

Diff:
---
 gdb/linux-nat.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index b33fac3d149..aeb81cd01bd 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -3620,10 +3620,7 @@ linux_xfer_siginfo (enum target_object object,
   if (offset > sizeof (siginfo))
     return TARGET_XFER_E_IO;
 
-  int pid = get_ptrace_pid (inferior_ptid);
-  errno = 0;
-  ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, &siginfo);
-  if (errno != 0)
+  if (!linux_nat_get_siginfo (inferior_ptid, &siginfo))
     return TARGET_XFER_E_IO;
 
   /* When GDB is built as a 64-bit application, ptrace writes into
@@ -3646,6 +3643,7 @@ linux_xfer_siginfo (enum target_object object,
       /* Convert back to ptrace layout before flushing it out.  */
       siginfo_fixup (&siginfo, inf_siginfo, 1);
 
+      int pid = get_ptrace_pid (inferior_ptid);
       errno = 0;
       ptrace (PTRACE_SETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, &siginfo);
       if (errno != 0)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-05 21:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 21:39 [binutils-gdb] gdb/linux-nat: use l linux_nat_get_siginfo in linux_xfer_siginfo Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).