public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop
@ 2022-12-13  2:34 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2022-12-13  2:34 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d0d41b77c0cda3b59bc8b82d3d1285db2203de56

commit d0d41b77c0cda3b59bc8b82d3d1285db2203de56
Author: Johnson Sun <j3.soon777@gmail.com>
Date:   Fri Sep 23 14:00:28 2022 +0800

    Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop
    
    In 2014, the function `gdbpy_should_stop' has been replaced with
    `gdbpy_breakpoint_cond_says_stop'
    
    This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the
    comments.
    
    Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014':
    
            * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed
            from gdbpy_should_stop.  Change result type to enum scr_bp_stop.
    
    Change-Id: I0ef3491ce5e057c5e75ef8b569803b30a5838575
    Approved-By: Simon Marchi <simon.marchi@efficios.com>

Diff:
---
 gdb/python/py-finishbreakpoint.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c
index 526657580ce..0b5dbeb5413 100644
--- a/gdb/python/py-finishbreakpoint.c
+++ b/gdb/python/py-finishbreakpoint.c
@@ -90,9 +90,9 @@ bpfinishpy_dealloc (PyObject *self)
   Py_TYPE (self)->tp_free (self);
 }
 
-/* Triggered when gdbpy_should_stop is about to execute the `stop' callback
-   of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and cache the
-   `return_value', if possible.  */
+/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop'
+   callback of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and cache
+   the `return_value', if possible.  */
 
 void
 bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj)
@@ -134,8 +134,8 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj)
     }
 }
 
-/* Triggered when gdbpy_should_stop has triggered the `stop' callback
-   of the gdb.FinishBreakpoint object BP_OBJ.  */
+/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop'
+   callback of the gdb.FinishBreakpoint object BP_OBJ.  */
 
 void
 bpfinishpy_post_stop_hook (struct gdbpy_breakpoint_object *bp_obj)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-13  2:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13  2:34 [binutils-gdb] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).