public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb/gdb-13-branch] Fix install-strip target
@ 2022-12-20 19:43 Hannes Domani
  0 siblings, 0 replies; only message in thread
From: Hannes Domani @ 2022-12-20 19:43 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a444d5309de3070cf385962b877c0b9a895274a6

commit a444d5309de3070cf385962b877c0b9a895274a6
Author: Hannes Domani <ssbssa@yahoo.de>
Date:   Mon Dec 19 17:29:27 2022 +0100

    Fix install-strip target
    
    The libtool patch broke install-strip of gdb:
    
    /bin/sh ../../gdb/../mkinstalldirs /src/gdb/inst/share/gdb/python/gdb
    transformed_name=`t='s,y,y,'; \
                      echo gdb | sed -e "$t"` ; \
            if test "x$transformed_name" = x; then \
              transformed_name=gdb ; \
            else \
              true ; \
            fi ; \
            /bin/sh ../../gdb/../mkinstalldirs /src/gdb/inst/bin ; \
            /bin/sh ./libtool --mode=install STRIPPROG='strip' /bin/sh /src/gdb/gdb.git/install-sh -c -s \
                    gdb \
                    /src/gdb/inst/bin/$transformed_name ; \
            /bin/sh ../../gdb/../mkinstalldirs /src/gdb/inst/include/gdb ; \
            /usr/bin/install -c -m 644 jit-reader.h /src/gdb/inst/include/gdb/jit-reader.h
    libtool: install: `/src/gdb/inst/bin/gdb' is not a directory
    libtool: install: Try `libtool --help --mode=install' for more information.
    
    Since INSTALL_PROGRAM_ENV is no longer at the beginning of the command, the
    gdb executable is not installed with install-strip.

Diff:
---
 gdb/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index fb4d42c7baa..192f8086aec 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2020,7 +2020,7 @@ install-only: $(CONFIG_INSTALL)
 		  true ; \
 		fi ; \
 		$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(bindir) ; \
-		$(LIBTOOL) --mode=install $(INSTALL_PROGRAM_ENV) $(INSTALL_PROGRAM) \
+		$(INSTALL_PROGRAM_ENV) $(LIBTOOL) --mode=install $(INSTALL_PROGRAM) \
 			gdb$(EXEEXT) \
 			$(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) ; \
 		$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(includedir)/gdb ; \
@@ -2533,7 +2533,7 @@ install-gdbtk:
 	  true ; \
 	fi ; \
 	$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(bindir); \
-	$(LIBTOOL) --mode=install $(INSTALL_PROGRAM_ENV) $(INSTALL_PROGRAM) \
+	$(INSTALL_PROGRAM_ENV) $(LIBTOOL) --mode=install $(INSTALL_PROGRAM) \
 		insight$(EXEEXT) \
 		$(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) ; \
 	$(SHELL) $(srcdir)/../mkinstalldirs \

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-20 19:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-20 19:43 [binutils-gdb/gdb-13-branch] Fix install-strip target Hannes Domani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).