public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite: remove MPFR detection in gdb.base/float128.exp
@ 2022-12-23 16:17 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2022-12-23 16:17 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c9397e5758137b75940e9cefcaaae499f86e7326
commit c9397e5758137b75940e9cefcaaae499f86e7326
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Thu Dec 22 10:10:24 2022 -0500
gdb/testsuite: remove MPFR detection in gdb.base/float128.exp
I see this fail since commit 991180627851 ("Use toplevel configure for
GMP and MPFR for gdb"):
FAIL: gdb.base/float128.exp: show configuration
The test fails to find --with-mpfr or --without-mpfr in the "show
configuration" output. Since MPFR has become mandatory, we can just
remove that check and simplify the test to assume MPFR support is there.
Change-Id: I4f3458470db0029705b390dfefed3a66dfc0633a
Approved-By: Tom de Vries <tdevries@suse.de>
Diff:
---
gdb/testsuite/gdb.base/float128.exp | 37 +------------------------------------
1 file changed, 1 insertion(+), 36 deletions(-)
diff --git a/gdb/testsuite/gdb.base/float128.exp b/gdb/testsuite/gdb.base/float128.exp
index 21a1a99f6ee..73835942ab0 100644
--- a/gdb/testsuite/gdb.base/float128.exp
+++ b/gdb/testsuite/gdb.base/float128.exp
@@ -73,40 +73,5 @@ gdb_test_multiple "set var f128=20.375l" "$test" {
gdb_test "print ld" ".* = 10\\.375.*" "the value of ld is changed to 10.375"
gdb_test "print f128" ".* = 20\\.375.*" "the value of f128 is changed to 20.375"
-set mpfr_supported -1
-gdb_test_multiple "show configuration" "" {
- -wrap -re "--with-mpfr\r\n.*" {
- set mpfr_supported 1
- }
- -wrap -re "--without-mpfr\r\n.*" {
- set mpfr_supported 0
- }
-}
-
# Test that we can correctly handle the largest IEEE-128 value
-# Note: If we get "inf" instead of the correct result, we may have run into
-# an internal overflow. This typically happens on host platforms without
-# native IEEE-128 support where GDB was built without MPFR support.
-set test "print large128"
-gdb_test_multiple "print large128" "$test" {
- -re ".* = 1\\.18973149535723176508575932662800702e\\+4932.*$gdb_prompt $" {
- pass "$test"
- }
- -re ".* = inf.*$gdb_prompt $" {
- if { $mpfr_supported == 0 } {
- # If the host platform has native 128-bit float support (as is
- # the case for some versions of s390 and powerpc), the
- # "print large128" test should be passing, even without MPFR
- # support. So, in those cases we should have fail here rather than
- # unsupported. However, given that we don't have a way to readily
- # test for this, we fall back to unsupported.
- unsupported "$test (Missing MPFR support)"
- } else {
- fail $test
- }
- }
- -re ".*$gdb_prompt $" {
- fail "$test"
- }
-}
-
+gdb_test "print large128" ".* = 1\\.18973149535723176508575932662800702e\\+4932"
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-23 16:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-23 16:17 [binutils-gdb] gdb/testsuite: remove MPFR detection in gdb.base/float128.exp Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).