public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/linespec.c: Fix -Wmaybe-uninitialized warning
@ 2023-01-10  1:13 Aaron Merey
  0 siblings, 0 replies; only message in thread
From: Aaron Merey @ 2023-01-10  1:13 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2ff63a29b0b01f949c8365f761e883d29709c44a

commit 2ff63a29b0b01f949c8365f761e883d29709c44a
Author: Aaron Merey <amerey@redhat.com>
Date:   Fri Jan 6 19:06:15 2023 -0500

    gdb/linespec.c: Fix -Wmaybe-uninitialized warning
    
    Although the bool want_start_sal isn't actually used without being assigned
    a value, initialize it to be false in order to prevent the following
    -Wmaybe-uninitialized warning:
    
        linespec.c: In function ‘void minsym_found(linespec_state*, objfile*, minimal_symbol*, std::vector<symtab_and_line>*)’:
        linespec.c:4150:19: warning: ‘want_start_sal’ may be used uninitialized [-Wmaybe-uninitialized]
         4150 |   if (is_function && want_start_sal)

Diff:
---
 gdb/linespec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/linespec.c b/gdb/linespec.c
index e9339c3338c..b8c77541a29 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -4129,7 +4129,7 @@ minsym_found (struct linespec_state *self, struct objfile *objfile,
 	      struct minimal_symbol *msymbol,
 	      std::vector<symtab_and_line> *result)
 {
-  bool want_start_sal;
+  bool want_start_sal = false;
 
   CORE_ADDR func_addr;
   bool is_function = msymbol_is_function (objfile, msymbol, &func_addr);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-10  1:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10  1:13 [binutils-gdb] gdb/linespec.c: Fix -Wmaybe-uninitialized warning Aaron Merey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).