public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] sim: msp430: move libsim.a creation to top-level
@ 2023-01-10 6:24 Michael Frysinger
0 siblings, 0 replies; only message in thread
From: Michael Frysinger @ 2023-01-10 6:24 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bff048f587342253c09d5b5af1e47afc96a4452a
commit bff048f587342253c09d5b5af1e47afc96a4452a
Author: Mike Frysinger <vapier@gentoo.org>
Date: Mon Dec 26 22:16:09 2022 -0500
sim: msp430: move libsim.a creation to top-level
The objects are still compiled in the subdir, but the creation of the
archive itself is in the top-level. This is a required step before we
can move compilation itself up, and makes it easier to review.
The downside is that each object compile is a recursive make instead of
a single one. On my 4 core system, it adds ~100msec to the build per
port, so it's not great, but it shouldn't be a big deal. This will go
away of course once the top-level compiles objects.
Diff:
---
sim/Makefile.in | 100 +++++++++++++++++++++++++++++++++----------------
sim/msp430/Makefile.in | 5 +--
sim/msp430/local.mk | 18 +++++++++
3 files changed, 86 insertions(+), 37 deletions(-)
diff --git a/sim/Makefile.in b/sim/Makefile.in
index 09d2e854e62..3d62ecca486 100644
--- a/sim/Makefile.in
+++ b/sim/Makefile.in
@@ -302,26 +302,27 @@ TESTS = testsuite/common/bits32m0$(EXEEXT) \
@SIM_ENABLE_ARCH_mn10300_TRUE@am__append_106 = $(mn10300_BUILD_OUTPUTS)
@SIM_ENABLE_ARCH_moxie_TRUE@am__append_107 = moxie/libsim.a
@SIM_ENABLE_ARCH_moxie_TRUE@am__append_108 = moxie/run
-@SIM_ENABLE_ARCH_msp430_TRUE@am__append_109 = msp430/run
-@SIM_ENABLE_ARCH_or1k_TRUE@am__append_110 = or1k/run
-@SIM_ENABLE_ARCH_or1k_TRUE@am__append_111 = or1k/eng.h
-@SIM_ENABLE_ARCH_or1k_TRUE@am__append_112 = $(or1k_BUILD_OUTPUTS)
+@SIM_ENABLE_ARCH_msp430_TRUE@am__append_109 = msp430/libsim.a
+@SIM_ENABLE_ARCH_msp430_TRUE@am__append_110 = msp430/run
+@SIM_ENABLE_ARCH_or1k_TRUE@am__append_111 = or1k/run
+@SIM_ENABLE_ARCH_or1k_TRUE@am__append_112 = or1k/eng.h
@SIM_ENABLE_ARCH_or1k_TRUE@am__append_113 = $(or1k_BUILD_OUTPUTS)
-@SIM_ENABLE_ARCH_ppc_TRUE@am__append_114 = ppc/run ppc/psim
-@SIM_ENABLE_ARCH_pru_TRUE@am__append_115 = pru/run
-@SIM_ENABLE_ARCH_riscv_TRUE@am__append_116 = riscv/run
-@SIM_ENABLE_ARCH_rl78_TRUE@am__append_117 = rl78/run
-@SIM_ENABLE_ARCH_rx_TRUE@am__append_118 = rx/run
-@SIM_ENABLE_ARCH_sh_TRUE@am__append_119 = sh/run
-@SIM_ENABLE_ARCH_sh_TRUE@am__append_120 = \
+@SIM_ENABLE_ARCH_or1k_TRUE@am__append_114 = $(or1k_BUILD_OUTPUTS)
+@SIM_ENABLE_ARCH_ppc_TRUE@am__append_115 = ppc/run ppc/psim
+@SIM_ENABLE_ARCH_pru_TRUE@am__append_116 = pru/run
+@SIM_ENABLE_ARCH_riscv_TRUE@am__append_117 = riscv/run
+@SIM_ENABLE_ARCH_rl78_TRUE@am__append_118 = rl78/run
+@SIM_ENABLE_ARCH_rx_TRUE@am__append_119 = rx/run
+@SIM_ENABLE_ARCH_sh_TRUE@am__append_120 = sh/run
+@SIM_ENABLE_ARCH_sh_TRUE@am__append_121 = \
@SIM_ENABLE_ARCH_sh_TRUE@ sh/code.c \
@SIM_ENABLE_ARCH_sh_TRUE@ sh/ppi.c
-@SIM_ENABLE_ARCH_sh_TRUE@am__append_121 = $(sh_BUILD_OUTPUTS)
-@SIM_ENABLE_ARCH_sh_TRUE@am__append_122 = sh/gencode
-@SIM_ENABLE_ARCH_sh_TRUE@am__append_123 = $(sh_BUILD_OUTPUTS)
-@SIM_ENABLE_ARCH_v850_TRUE@am__append_124 = v850/run
-@SIM_ENABLE_ARCH_v850_TRUE@am__append_125 = \
+@SIM_ENABLE_ARCH_sh_TRUE@am__append_122 = $(sh_BUILD_OUTPUTS)
+@SIM_ENABLE_ARCH_sh_TRUE@am__append_123 = sh/gencode
+@SIM_ENABLE_ARCH_sh_TRUE@am__append_124 = $(sh_BUILD_OUTPUTS)
+@SIM_ENABLE_ARCH_v850_TRUE@am__append_125 = v850/run
+@SIM_ENABLE_ARCH_v850_TRUE@am__append_126 = \
@SIM_ENABLE_ARCH_v850_TRUE@ v850/icache.h \
@SIM_ENABLE_ARCH_v850_TRUE@ v850/idecode.h \
@SIM_ENABLE_ARCH_v850_TRUE@ v850/semantics.h \
@@ -330,8 +331,8 @@ TESTS = testsuite/common/bits32m0$(EXEEXT) \
@SIM_ENABLE_ARCH_v850_TRUE@ v850/itable.h \
@SIM_ENABLE_ARCH_v850_TRUE@ v850/engine.h
-@SIM_ENABLE_ARCH_v850_TRUE@am__append_126 = $(v850_BUILD_OUTPUTS)
@SIM_ENABLE_ARCH_v850_TRUE@am__append_127 = $(v850_BUILD_OUTPUTS)
+@SIM_ENABLE_ARCH_v850_TRUE@am__append_128 = $(v850_BUILD_OUTPUTS)
subdir = .
ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \
@@ -768,6 +769,18 @@ moxie_libsim_a_AR = $(AR) $(ARFLAGS)
@SIM_ENABLE_ARCH_moxie_TRUE@ moxie/sim-resume.o
am_moxie_libsim_a_OBJECTS =
moxie_libsim_a_OBJECTS = $(am_moxie_libsim_a_OBJECTS)
+msp430_libsim_a_AR = $(AR) $(ARFLAGS)
+@SIM_ENABLE_ARCH_msp430_TRUE@msp430_libsim_a_DEPENDENCIES = \
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(common_libcommon_a_OBJECTS) \
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(patsubst \
+@SIM_ENABLE_ARCH_msp430_TRUE@ %,msp430/%,$(SIM_NEW_COMMON_OBJS)) \
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(patsubst \
+@SIM_ENABLE_ARCH_msp430_TRUE@ %,msp430/dv-%.o,$(SIM_HW_DEVICES)) \
+@SIM_ENABLE_ARCH_msp430_TRUE@ msp430/msp430-sim.o \
+@SIM_ENABLE_ARCH_msp430_TRUE@ msp430/modules.o \
+@SIM_ENABLE_ARCH_msp430_TRUE@ msp430/sim-resume.o
+am_msp430_libsim_a_OBJECTS =
+msp430_libsim_a_OBJECTS = $(am_msp430_libsim_a_OBJECTS)
@SIM_ENABLE_IGEN_TRUE@am__EXEEXT_1 = $(IGEN) igen/filter$(EXEEXT) \
@SIM_ENABLE_IGEN_TRUE@ igen/gen$(EXEEXT) igen/ld-cache$(EXEEXT) \
@SIM_ENABLE_IGEN_TRUE@ igen/ld-decode$(EXEEXT) \
@@ -1102,12 +1115,12 @@ SOURCES = $(aarch64_libsim_a_SOURCES) $(arm_libsim_a_SOURCES) \
$(m32r_libsim_a_SOURCES) $(m68hc11_libsim_a_SOURCES) \
$(mcore_libsim_a_SOURCES) $(microblaze_libsim_a_SOURCES) \
$(mips_libsim_a_SOURCES) $(mn10300_libsim_a_SOURCES) \
- $(moxie_libsim_a_SOURCES) $(aarch64_run_SOURCES) \
- $(arm_run_SOURCES) $(avr_run_SOURCES) $(bfin_run_SOURCES) \
- $(bpf_run_SOURCES) $(cr16_gencode_SOURCES) $(cr16_run_SOURCES) \
- $(cris_run_SOURCES) $(cris_rvdummy_SOURCES) \
- $(d10v_gencode_SOURCES) $(d10v_run_SOURCES) \
- $(erc32_run_SOURCES) erc32/sis.c \
+ $(moxie_libsim_a_SOURCES) $(msp430_libsim_a_SOURCES) \
+ $(aarch64_run_SOURCES) $(arm_run_SOURCES) $(avr_run_SOURCES) \
+ $(bfin_run_SOURCES) $(bpf_run_SOURCES) $(cr16_gencode_SOURCES) \
+ $(cr16_run_SOURCES) $(cris_run_SOURCES) \
+ $(cris_rvdummy_SOURCES) $(d10v_gencode_SOURCES) \
+ $(d10v_run_SOURCES) $(erc32_run_SOURCES) erc32/sis.c \
$(example_synacor_run_SOURCES) $(frv_run_SOURCES) \
$(ft32_run_SOURCES) $(h8300_run_SOURCES) \
$(igen_filter_SOURCES) $(igen_gen_SOURCES) \
@@ -1670,12 +1683,12 @@ noinst_LIBRARIES = common/libcommon.a $(am__append_5) $(am__append_8) \
$(am__append_56) $(am__append_61) $(am__append_67) \
$(am__append_72) $(am__append_78) $(am__append_84) \
$(am__append_86) $(am__append_91) $(am__append_101) \
- $(am__append_107)
+ $(am__append_107) $(am__append_109)
BUILT_SOURCES = $(am__append_19) $(am__append_24) $(am__append_32) \
$(am__append_37) $(am__append_49) $(am__append_58) \
$(am__append_64) $(am__append_75) $(am__append_94) \
- $(am__append_104) $(am__append_111) $(am__append_120) \
- $(am__append_125)
+ $(am__append_104) $(am__append_112) $(am__append_121) \
+ $(am__append_126)
CLEANFILES = common/version.c common/version.c-stamp \
testsuite/common/bits-gen testsuite/common/bits32m0.c \
testsuite/common/bits32m31.c testsuite/common/bits64m0.c \
@@ -1689,8 +1702,8 @@ MOSTLYCLEANFILES = core $(common_HW_CONFIG_H_TARGETS) $(patsubst \
$(am__append_27) $(am__append_34) $(am__append_40) \
$(am__append_51) $(am__append_60) $(am__append_66) \
$(am__append_71) $(am__append_77) $(am__append_83) \
- $(am__append_99) $(am__append_106) $(am__append_113) \
- $(am__append_123) $(am__append_127)
+ $(am__append_99) $(am__append_106) $(am__append_114) \
+ $(am__append_124) $(am__append_128)
AM_CFLAGS = $(WERROR_CFLAGS) $(WARN_CFLAGS)
AM_CPPFLAGS = $(INCGNU) -I$(srcroot)/include -I../bfd -I.. \
$(SIM_HW_CFLAGS) $(SIM_INLINE) -I$(srcdir)/common \
@@ -1705,8 +1718,8 @@ SIM_ALL_RECURSIVE_DEPS = common/libcommon.a \
$(am__append_33) $(am__append_38) $(am__append_50) \
$(am__append_59) $(am__append_65) $(am__append_69) \
$(am__append_76) $(am__append_81) $(am__append_98) \
- $(am__append_105) $(am__append_112) $(am__append_121) \
- $(am__append_126)
+ $(am__append_105) $(am__append_113) $(am__append_122) \
+ $(am__append_127)
SIM_INSTALL_DATA_LOCAL_DEPS =
SIM_INSTALL_EXEC_LOCAL_DEPS = $(am__append_43)
SIM_UNINSTALL_LOCAL_DEPS = $(am__append_44)
@@ -2595,6 +2608,15 @@ testsuite_common_CPPFLAGS = \
@SIM_ENABLE_ARCH_moxie_TRUE@dtbdir = $(datadir)/gdb/dtb
@SIM_ENABLE_ARCH_moxie_TRUE@dtb_DATA = moxie/moxie-gdb.dtb
+@SIM_ENABLE_ARCH_msp430_TRUE@msp430_libsim_a_SOURCES =
+@SIM_ENABLE_ARCH_msp430_TRUE@msp430_libsim_a_LIBADD = \
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(common_libcommon_a_OBJECTS) \
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(patsubst %,msp430/%,$(SIM_NEW_COMMON_OBJS)) \
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(patsubst %,msp430/dv-%.o,$(SIM_HW_DEVICES)) \
+@SIM_ENABLE_ARCH_msp430_TRUE@ msp430/msp430-sim.o \
+@SIM_ENABLE_ARCH_msp430_TRUE@ msp430/modules.o \
+@SIM_ENABLE_ARCH_msp430_TRUE@ msp430/sim-resume.o
+
@SIM_ENABLE_ARCH_msp430_TRUE@msp430_run_SOURCES =
@SIM_ENABLE_ARCH_msp430_TRUE@msp430_run_LDADD = \
@SIM_ENABLE_ARCH_msp430_TRUE@ msp430/nrun.o \
@@ -3132,6 +3154,14 @@ moxie/libsim.a: $(moxie_libsim_a_OBJECTS) $(moxie_libsim_a_DEPENDENCIES) $(EXTRA
$(AM_V_at)-rm -f moxie/libsim.a
$(AM_V_AR)$(moxie_libsim_a_AR) moxie/libsim.a $(moxie_libsim_a_OBJECTS) $(moxie_libsim_a_LIBADD)
$(AM_V_at)$(RANLIB) moxie/libsim.a
+msp430/$(am__dirstamp):
+ @$(MKDIR_P) msp430
+ @: > msp430/$(am__dirstamp)
+
+msp430/libsim.a: $(msp430_libsim_a_OBJECTS) $(msp430_libsim_a_DEPENDENCIES) $(EXTRA_msp430_libsim_a_DEPENDENCIES) msp430/$(am__dirstamp)
+ $(AM_V_at)-rm -f msp430/libsim.a
+ $(AM_V_AR)$(msp430_libsim_a_AR) msp430/libsim.a $(msp430_libsim_a_OBJECTS) $(msp430_libsim_a_LIBADD)
+ $(AM_V_at)$(RANLIB) msp430/libsim.a
clean-checkPROGRAMS:
@list='$(check_PROGRAMS)'; test -n "$$list" || exit 0; \
@@ -3326,9 +3356,6 @@ mn10300/run$(EXEEXT): $(mn10300_run_OBJECTS) $(mn10300_run_DEPENDENCIES) $(EXTRA
moxie/run$(EXEEXT): $(moxie_run_OBJECTS) $(moxie_run_DEPENDENCIES) $(EXTRA_moxie_run_DEPENDENCIES) moxie/$(am__dirstamp)
@rm -f moxie/run$(EXEEXT)
$(AM_V_CCLD)$(LINK) $(moxie_run_OBJECTS) $(moxie_run_LDADD) $(LIBS)
-msp430/$(am__dirstamp):
- @$(MKDIR_P) msp430
- @: > msp430/$(am__dirstamp)
msp430/run$(EXEEXT): $(msp430_run_OBJECTS) $(msp430_run_DEPENDENCIES) $(EXTRA_msp430_run_DEPENDENCIES) msp430/$(am__dirstamp)
@rm -f msp430/run$(EXEEXT)
@@ -5092,6 +5119,13 @@ testsuite/common/bits64m63.c: testsuite/common/bits-gen$(EXEEXT) testsuite/commo
@SIM_ENABLE_ARCH_moxie_TRUE@ echo "tree compiler tool (dtc) is missing. Install the tool to "; \
@SIM_ENABLE_ARCH_moxie_TRUE@ echo "update the device tree blob."; \
@SIM_ENABLE_ARCH_moxie_TRUE@ fi
+@SIM_ENABLE_ARCH_msp430_TRUE@$(msp430_libsim_a_OBJECTS) $(msp430_libsim_a_LIBADD): msp430/hw-config.h
+
+@SIM_ENABLE_ARCH_msp430_TRUE@msp430/%.o: msp430/%.c
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
+
+@SIM_ENABLE_ARCH_msp430_TRUE@msp430/%.o: common/%.c
+@SIM_ENABLE_ARCH_msp430_TRUE@ $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
@SIM_ENABLE_ARCH_or1k_TRUE@or1k/modules.c: | $(or1k_BUILD_OUTPUTS)
@SIM_ENABLE_ARCH_or1k_TRUE@or1k/mloop.c or1k/eng.h: or1k/stamp-mloop ; @true
diff --git a/sim/msp430/Makefile.in b/sim/msp430/Makefile.in
index 82c21a16fc9..5cdf3096a7a 100644
--- a/sim/msp430/Makefile.in
+++ b/sim/msp430/Makefile.in
@@ -18,9 +18,6 @@
## COMMON_PRE_CONFIG_FRAG
-SIM_OBJS = \
- $(SIM_NEW_COMMON_OBJS) \
- msp430-sim.o \
- sim-resume.o
+SIM_LIBSIM =
## COMMON_POST_CONFIG_FRAG
diff --git a/sim/msp430/local.mk b/sim/msp430/local.mk
index c9f4451943c..772d12f0a17 100644
--- a/sim/msp430/local.mk
+++ b/sim/msp430/local.mk
@@ -16,6 +16,24 @@
## You should have received a copy of the GNU General Public License
## along with this program. If not, see <http://www.gnu.org/licenses/>.
+%C%_libsim_a_SOURCES =
+%C%_libsim_a_LIBADD = \
+ $(common_libcommon_a_OBJECTS) \
+ $(patsubst %,%D%/%,$(SIM_NEW_COMMON_OBJS)) \
+ $(patsubst %,%D%/dv-%.o,$(SIM_HW_DEVICES)) \
+ %D%/msp430-sim.o \
+ %D%/modules.o \
+ %D%/sim-resume.o
+$(%C%_libsim_a_OBJECTS) $(%C%_libsim_a_LIBADD): %D%/hw-config.h
+
+noinst_LIBRARIES += %D%/libsim.a
+
+%D%/%.o: %D%/%.c
+ $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
+
+%D%/%.o: common/%.c
+ $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
+
%C%_run_SOURCES =
%C%_run_LDADD = \
%D%/nrun.o \
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-10 6:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 6:24 [binutils-gdb] sim: msp430: move libsim.a creation to top-level Michael Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).