public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Pass internal gdb flags to --configuration invocations Date: Sat, 14 Jan 2023 19:49:05 +0000 (GMT) [thread overview] Message-ID: <20230114194905.0C6393858D1E@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=856cd0786ccea2f0b39d36024187c415e0a27d76 commit 856cd0786ccea2f0b39d36024187c415e0a27d76 Author: Tom Tromey <tom@tromey.com> Date: Sat Jan 14 12:42:30 2023 -0700 Pass internal gdb flags to --configuration invocations The test suite uses the --configuration flag to feature-test gdb. However, when I added this, I neglected to pass the internal gdbflags to this, causing an error, which then caused failures in the test suite (which would not be seen if you'd ever run "make install"). This patch fixes the bug. Tested by removing my install tree first, to verify that I could reproduce the failure. Diff: --- gdb/testsuite/lib/gdb-guile.exp | 2 +- gdb/testsuite/lib/gdb.exp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/lib/gdb-guile.exp b/gdb/testsuite/lib/gdb-guile.exp index f2307372b8b..50189c8ed90 100644 --- a/gdb/testsuite/lib/gdb-guile.exp +++ b/gdb/testsuite/lib/gdb-guile.exp @@ -21,7 +21,7 @@ set ghex {[0-9a-f]+} # Return a 1 for configurations that support Guile scripting. gdb_caching_proc allow_guile_tests { - set output [exec $::GDB --configuration] + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"] return [expr {[string first "--with-guile" $output] != -1}] } diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 5359315667e..68337bd235c 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2450,7 +2450,7 @@ proc allow_rust_tests {} { # Return a 1 for configurations that support Python scripting. gdb_caching_proc allow_python_tests { - set output [remote_exec host $::GDB --configuration] + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"] return [expr {[string first "--with-python" $output] != -1}] } @@ -2575,7 +2575,7 @@ gdb_caching_proc allow_dlmopen_tests { # Return 1 if we should allow TUI-related tests. gdb_caching_proc allow_tui_tests { - set output [remote_exec host $::GDB --configuration] + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"] return [expr {[string first "--enable-tui" $output] != -1}] }
reply other threads:[~2023-01-14 19:49 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230114194905.0C6393858D1E@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).