public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Move target check into allow_altivec_tests Date: Wed, 25 Jan 2023 16:21:42 +0000 (GMT) [thread overview] Message-ID: <20230125162142.820E73858C83@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d8f5b7d1d1e8e1f0352848b7066dd133edd50773 commit d8f5b7d1d1e8e1f0352848b7066dd133edd50773 Author: Tom Tromey <tom@tromey.com> Date: Tue Jan 24 12:50:20 2023 -0700 Move target check into allow_altivec_tests Pedro pointed out that only PPC can possibly have altivec, so we can move the target check into allow_altivec_tests. Diff: --- gdb/testsuite/gdb.arch/altivec-abi.exp | 1 - gdb/testsuite/gdb.arch/altivec-regs.exp | 1 - gdb/testsuite/gdb.arch/powerpc-vector-regs.exp | 2 +- gdb/testsuite/lib/gdb.exp | 5 +++++ 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.arch/altivec-abi.exp b/gdb/testsuite/gdb.arch/altivec-abi.exp index 2cc75d4d617..b04858950e8 100644 --- a/gdb/testsuite/gdb.arch/altivec-abi.exp +++ b/gdb/testsuite/gdb.arch/altivec-abi.exp @@ -22,7 +22,6 @@ # require allow_altivec_tests -require {istarget "powerpc*"} standard_testfile diff --git a/gdb/testsuite/gdb.arch/altivec-regs.exp b/gdb/testsuite/gdb.arch/altivec-regs.exp index 315ce1acfb2..6cc32aeff22 100644 --- a/gdb/testsuite/gdb.arch/altivec-regs.exp +++ b/gdb/testsuite/gdb.arch/altivec-regs.exp @@ -22,7 +22,6 @@ # require allow_altivec_tests -require {istarget "powerpc*"} standard_testfile diff --git a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp index 2447d740624..2958af019cb 100644 --- a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp +++ b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp @@ -20,7 +20,7 @@ # 0 to 31 in each of the 16 bytes of each corresponding register, and # we then check if gdb sees these same values. -require allow_altivec_tests {[istarget "powerpc*"} +require allow_altivec_tests standard_testfile diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index d30340e1df1..e2af5a252b7 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3471,6 +3471,11 @@ gdb_caching_proc allow_altivec_tests { return 0 } + if {![istarget powerpc*]} { + verbose "$me: PPC target required, returning 0" 2 + return 0 + } + # Make sure we have a compiler that understands altivec. if [test_compiler_info gcc*] { set compile_flags "additional_flags=-maltivec"
reply other threads:[~2023-01-25 16:21 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230125162142.820E73858C83@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).