public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Start gdb after building executable in mi-basics.exp Date: Fri, 27 Jan 2023 01:29:20 +0000 (GMT) [thread overview] Message-ID: <20230127012920.BE04C3858D28@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d6acf25c03f8c507e134f7438bd4360464ce111e commit d6acf25c03f8c507e134f7438bd4360464ce111e Author: Tom Tromey <tom@tromey.com> Date: Wed Jan 25 10:00:58 2023 -0700 Start gdb after building executable in mi-basics.exp A lot of the MI tests start gdb and only then build the executable. This just seemed weird to me, so I've fixed this up. In this patch, no other cleanups are done, the startup is just moved to a more logical (to me) spot. Diff: --- gdb/testsuite/gdb.mi/mi-basics.exp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-basics.exp b/gdb/testsuite/gdb.mi/mi-basics.exp index 086ce74eae5..30d0da6ed02 100644 --- a/gdb/testsuite/gdb.mi/mi-basics.exp +++ b/gdb/testsuite/gdb.mi/mi-basics.exp @@ -28,11 +28,6 @@ load_lib mi-support.exp set MIFLAGS "-i=mi" -gdb_exit -if [mi_gdb_start separate-inferior-tty] { - return -} - standard_testfile basics.c # This file was audited to ensure that the explicit references to # objdir in it are safe for parallel testing. Please be sure to @@ -49,6 +44,11 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb # In this file we want to test if the operations needed by the following # procedures work, so it makes no sense using them here. +gdb_exit +if [mi_gdb_start separate-inferior-tty] { + return +} + # mi_delete_breakpoints # mi_gdb_reinitialize_dir $srcdir/$subdir # mi_gdb_load ${binfile}
reply other threads:[~2023-01-27 1:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230127012920.BE04C3858D28@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).