public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Improve untested message in gdb.ada/finish-var-size.exp Date: Tue, 7 Feb 2023 10:41:48 +0000 (GMT) [thread overview] Message-ID: <20230207104148.A48D33858D33@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ca2f51c6960d65c2d3adbc4095aa8a9d02759376 commit ca2f51c6960d65c2d3adbc4095aa8a9d02759376 Author: Tom de Vries <tdevries@suse.de> Date: Tue Feb 7 11:41:44 2023 +0100 [gdb/testsuite] Improve untested message in gdb.ada/finish-var-size.exp I came across: ... UNTESTED: gdb.ada/finish-var-size.exp: GCC too told for this test ... The message only tells us that the compiler version too old, not what compiler version is required. Fix this by rewriting using required: ... UNSUPPORTED: gdb.ada/finish-var-size.exp: require failed: \ expr [gcc_major_version] >= 12 ... Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.ada/finish-var-size.exp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.ada/finish-var-size.exp b/gdb/testsuite/gdb.ada/finish-var-size.exp index c1cf6406433..5865be249a0 100644 --- a/gdb/testsuite/gdb.ada/finish-var-size.exp +++ b/gdb/testsuite/gdb.ada/finish-var-size.exp @@ -18,10 +18,7 @@ load_lib "ada.exp" require allow_ada_tests # GCC 12 has the needed fix. -if {![test_compiler_info {gcc-1[2-9]-*}]} { - untested "GCC too told for this test" - return -1 -} +require {expr [gcc_major_version] >= 12} standard_ada_testfile p
reply other threads:[~2023-02-07 10:41 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230207104148.A48D33858D33@sourceware.org \ --to=vries@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).