public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Trivially simplify rust_language::print_enum Date: Thu, 9 Feb 2023 19:22:31 +0000 (GMT) [thread overview] Message-ID: <20230209192231.81DC53858C62@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8ac460b742bc7f49acbcd78f8822386f56814055 commit 8ac460b742bc7f49acbcd78f8822386f56814055 Author: Tom Tromey <tom@tromey.com> Date: Thu Feb 9 12:13:08 2023 -0700 Trivially simplify rust_language::print_enum rust_language::print_enum computes: int nfields = variant_type->num_fields (); ... but then does not reuse this in one spot. This patch corrects the oversight. Diff: --- gdb/rust-lang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c index 6653f7a9c64..f2017f95211 100644 --- a/gdb/rust-lang.c +++ b/gdb/rust-lang.c @@ -495,7 +495,7 @@ rust_language::print_enum (struct value *val, struct ui_file *stream, } bool first_field = true; - for (int j = 0; j < variant_type->num_fields (); j++) + for (int j = 0; j < nfields; j++) { if (!first_field) gdb_puts (", ", stream);
reply other threads:[~2023-02-09 19:22 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230209192231.81DC53858C62@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).