public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: fix describe_other_breakpoints for default task being -1
Date: Sun, 12 Feb 2023 07:21:20 +0000 (GMT)	[thread overview]
Message-ID: <20230212072120.3BF293858D32@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8282ad74c302a8e0db7a588e500ae117a1df68c5

commit 8282ad74c302a8e0db7a588e500ae117a1df68c5
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Sun Feb 12 07:14:31 2023 +0000

    gdb: fix describe_other_breakpoints for default task being -1
    
    Commit:
    
      commit 2ecee236752932672fb3d6cd63c6976927f747d8
      CommitDate: Sun Feb 12 05:46:44 2023 +0000
    
          gdb: use -1 for breakpoint::task default value
    
    Failed to take account of an earlier commit:
    
      commit f1f517e81039f6aa673b7d87a66bfbd25a66e3d3
      CommitDate: Sat Feb 11 17:36:24 2023 +0000
    
          gdb: show task number in describe_other_breakpoints
    
    That both of these are my own commits is only more embarrassing.
    
    This small fix updates describe_other_breakpoints to take account of
    the default task number now being -1.  This fixes regressions in
    gdb.base/break.exp, gdb.base/break-always.exp, and many other tests.

Diff:
---
 gdb/breakpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 4b0a909d60c..97dee5cd0fe 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7057,7 +7057,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
 		struct thread_info *thr = find_thread_global_id (b->thread);
 		gdb_printf (" (thread %s)", print_thread_id (thr));
 	      }
-	    else if (b->task != 0)
+	    else if (b->task != -1)
 	      gdb_printf (" (task %d)", b->task);
 	    gdb_printf ("%s%s ",
 			((b->enable_state == bp_disabled

                 reply	other threads:[~2023-02-12  7:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230212072120.3BF293858D32@sourceware.org \
    --to=aburgess@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).