public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests
@ 2023-02-13 9:52 Lancelot SIX
0 siblings, 0 replies; only message in thread
From: Lancelot SIX @ 2023-02-13 9:52 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=09ad7eb8cc670356aff71e59b22038590c397a21
commit 09ad7eb8cc670356aff71e59b22038590c397a21
Author: Lancelot SIX <lancelot.six@amd.com>
Date: Mon Feb 6 18:05:31 2023 +0000
gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests
Rename skip_hipcc_tests to allow_hipcc_tests so it can be used as a
"require" predicate in tests.
Use require in gdb.rocm/simple.exp.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diff:
---
gdb/testsuite/gdb.rocm/simple.exp | 5 +----
gdb/testsuite/lib/rocm.exp | 6 +++---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/gdb/testsuite/gdb.rocm/simple.exp b/gdb/testsuite/gdb.rocm/simple.exp
index f84df71414e..befcc7aaabc 100644
--- a/gdb/testsuite/gdb.rocm/simple.exp
+++ b/gdb/testsuite/gdb.rocm/simple.exp
@@ -20,10 +20,7 @@ load_lib rocm.exp
standard_testfile .cpp
-if [skip_hipcc_tests] {
- verbose "skipping hip test: ${testfile}"
- return
-}
+require allow_hipcc_tests
if {[build_executable "failed to prepare" $testfile $srcfile {debug hip}]} {
return
diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp
index e22f392deb1..1440ac85d32 100644
--- a/gdb/testsuite/lib/rocm.exp
+++ b/gdb/testsuite/lib/rocm.exp
@@ -15,14 +15,14 @@
#
# Support library for testing ROCm (AMD GPU) GDB features.
-proc skip_hipcc_tests { } {
+proc allow_hipcc_tests { } {
# Only the native target supports ROCm debugging. E.g., when
# testing against GDBserver, there's no point in running the ROCm
# tests.
if {[target_info gdb_protocol] != ""} {
- return 1
+ return 0
}
- return 0
+ return 1
}
# The lock file used to ensure that only one GDB has access to the GPU
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-13 9:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 9:52 [binutils-gdb] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests Lancelot SIX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).