public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Rearrange block.c to avoid a forward declaration
@ 2023-02-19 23:36 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-02-19 23:36 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4aabc4166430fed52e9a2e4042147e3480f9178a
commit 4aabc4166430fed52e9a2e4042147e3480f9178a
Author: Tom Tromey <tom@tromey.com>
Date: Mon Jan 16 17:04:55 2023 -0700
Rearrange block.c to avoid a forward declaration
Moving block_initialize_namespace before its callers lets us avoid a
forward declaration.
Diff:
---
gdb/block.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/gdb/block.c b/gdb/block.c
index 167cb08e0bb..751f67d30f7 100644
--- a/gdb/block.c
+++ b/gdb/block.c
@@ -37,9 +37,6 @@ struct block_namespace_info : public allocate_on_obstack
struct using_direct *using_decl = nullptr;
};
-static void block_initialize_namespace (struct block *block,
- struct obstack *obstack);
-
/* See block.h. */
struct objfile *
@@ -305,6 +302,16 @@ block_scope (const struct block *block)
return "";
}
+/* If block->namespace_info () is NULL, allocate it via OBSTACK and
+ initialize its members to zero. */
+
+static void
+block_initialize_namespace (struct block *block, struct obstack *obstack)
+{
+ if (block->namespace_info () == NULL)
+ block->set_namespace_info (new (obstack) struct block_namespace_info ());
+}
+
/* Set BLOCK's scope member to SCOPE; if needed, allocate memory via
OBSTACK. (It won't make a copy of SCOPE, however, so that already
has to be allocated correctly.) */
@@ -344,16 +351,6 @@ block_set_using (struct block *block,
block->namespace_info ()->using_decl = using_decl;
}
-/* If block->namespace_info () is NULL, allocate it via OBSTACK and
- initialize its members to zero. */
-
-static void
-block_initialize_namespace (struct block *block, struct obstack *obstack)
-{
- if (block->namespace_info () == NULL)
- block->set_namespace_info (new (obstack) struct block_namespace_info ());
-}
-
/* Return the static block associated to BLOCK. Return NULL if block
is NULL or if block is a global block. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-19 23:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-19 23:36 [binutils-gdb] Rearrange block.c to avoid a forward declaration Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).