public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb, python: do minor modernization in execute_gdb_command
@ 2023-02-27 9:32 Tankut Baris Aktemur
0 siblings, 0 replies; only message in thread
From: Tankut Baris Aktemur @ 2023-02-27 9:32 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4e08903f679f22be6d7ea6e33f21a9fc43210567
commit 4e08903f679f22be6d7ea6e33f21a9fc43210567
Author: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Date: Mon Feb 27 10:28:40 2023 +0100
gdb, python: do minor modernization in execute_gdb_command
Use nullptr instead of NULL and boolify two local variables in
execute_gdb_command.
Approved-By: Tom Tromey <tom@tromey.com>
Diff:
---
gdb/python/python.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/gdb/python/python.c b/gdb/python/python.c
index ed466cc4511..1ed13f2789b 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -621,31 +621,32 @@ static PyObject *
execute_gdb_command (PyObject *self, PyObject *args, PyObject *kw)
{
const char *arg;
- PyObject *from_tty_obj = NULL, *to_string_obj = NULL;
- int from_tty, to_string;
- static const char *keywords[] = { "command", "from_tty", "to_string", NULL };
+ PyObject *from_tty_obj = nullptr;
+ PyObject *to_string_obj = nullptr;
+ static const char *keywords[] = { "command", "from_tty", "to_string",
+ nullptr };
if (!gdb_PyArg_ParseTupleAndKeywords (args, kw, "s|O!O!", keywords, &arg,
&PyBool_Type, &from_tty_obj,
&PyBool_Type, &to_string_obj))
- return NULL;
+ return nullptr;
- from_tty = 0;
- if (from_tty_obj)
+ bool from_tty = false;
+ if (from_tty_obj != nullptr)
{
int cmp = PyObject_IsTrue (from_tty_obj);
if (cmp < 0)
- return NULL;
- from_tty = cmp;
+ return nullptr;
+ from_tty = (cmp != 0);
}
- to_string = 0;
- if (to_string_obj)
+ bool to_string = false;
+ if (to_string_obj != nullptr)
{
int cmp = PyObject_IsTrue (to_string_obj);
if (cmp < 0)
- return NULL;
- to_string = cmp;
+ return nullptr;
+ to_string = (cmp != 0);
}
std::string to_string_res;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-27 9:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-27 9:32 [binutils-gdb] gdb, python: do minor modernization in execute_gdb_command Tankut Baris Aktemur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).